Skip to content

Conversation

@niiyeboah
Copy link

@niiyeboah niiyeboah commented Mar 22, 2021

  • Add dispatch cell-focus event on cell-focusin
  • Add cell-focus test

Connected to vaadin/vaadin-grid#1536

Add dispatch cell-focus event on cell-focusin
Add cell-focus test
@niiyeboah niiyeboah force-pushed the grid/cell-focus-event branch from ce4dbf4 to ffcd099 Compare March 22, 2021 15:25
Add event context test
@tomivirkki
Copy link
Member

Prefer using the conventional commit style in the PR title also, to make sure the merge commit is formatted properly.

@niiyeboah niiyeboah changed the title grid: cell-focus event feat(grid): cell-focus event Mar 25, 2021
@niiyeboah niiyeboah force-pushed the grid/cell-focus-event branch from 10c0f0f to 0d44700 Compare March 25, 2021 14:17
@niiyeboah
Copy link
Author

Should I change the title to just be feat:? I left the (grid) to show the scope but if that's not best practice I won't do that

@tomivirkki tomivirkki changed the title feat(grid): cell-focus event feat: cell-focus event Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants