Added nn.ModuleList to GCNModel intermediat_layers #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intermediate layers of the
GCNModel
are not wrapped in atoch.nn.ModuleList
. Even though the layers will be part of the computational graph and used to calculate the output (forward
function) they will not receive updates. Thus, the loss values stagnate faster. Below is a table comparing the before and after (usingtorch.nn.ModuleList
results in loss and predictions in accordance with the high level classtorch_geometric.nn.GCN
).