Skip to content

Commit 7b2fbe8

Browse files
committed
fix: subscribeEvents issue for non-prologue partitions
Scribe was setting subscribeEvents as false even when it never makes a follow-up narrateEventLog call.
1 parent 87d30c0 commit 7b2fbe8

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

packages/prophet/Oracle/OraclePartitionConnection.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,7 @@ export default class OraclePartitionConnection extends PartitionConnection {
4343
this.setUpstreamConnection(this._authorityProphet.acquirePartitionConnection(
4444
this.getPartitionURI(), {
4545
narrateOptions: false,
46-
subscribeEvents:
47-
(options.narrateOptions === false) && (options.subscribeEvents !== false),
46+
subscribeEvents: (options.narrateOptions === false) && options.subscribeEvents,
4847
receiveTruths: this.getReceiveTruths(options.receiveTruths),
4948
}));
5049
return thenChainEagerly(

packages/prophet/Scribe/ScribePartitionConnection.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,8 @@ export default class ScribePartitionConnection extends PartitionConnection {
7474
// the initial optimistic narrateEventLog later below using
7575
// options.receiveTruths.
7676
...options,
77-
receiveTruths: this.getReceiveTruths(), narrateOptions: false, subscribeEvents: false,
77+
receiveTruths: this.getReceiveTruths(), narrateOptions: false,
78+
subscribeEvents: (options.narrateOptions === false) && options.subscribeEvents,
7879
}));
7980
}
8081
// ScribePartitionConnection can be active even if the upstream

0 commit comments

Comments
 (0)