fix: valma logging and pool bugs, text changes, toolset command bugs

Extracts perspire revelationPath&additionalRevelationPaths
  from revelationPaths

Author: iridiankin

package.json

@@ -27,8 +27,8 @@
     "publish-packages": "vlm publish-packages "
   },
   "devDependencies": {
-    "@valos/toolset-revealer": ">0.33.0-prerelease",
-    "@valos/toolset-vault": ">0.33.0-prerelease",
-    "valma": ">0.33.0-prerelease"
+    "@valos/toolset-revealer": ">0.34.0-prerelease",
+    "@valos/toolset-vault": ">0.34.0-prerelease",
+    "valma": ">0.34.0-prerelease"
   }
 }

packages/engine/debugId.js

@@ -1,8 +1,8 @@
 // @flow
 
 import { getTransientTypeName } from "~/raem/state/Transient";
-import dumpify from "~/tools/dumpify";
 
+const dumpify = require("~/tools/dumpify").default;
 const isSymbol = require("~/tools/isSymbol").default;
 
 export default function debugId (object: any, options: any) {

packages/inspire/ui/Presentable.js

@@ -1,6 +1,7 @@
-import dumpify from "~/tools/dumpify";
 import { unthunkRepeat } from "~/inspire/ui/thunk";
 
+const dumpify = require("~/tools/dumpify").default;
+
 // TODO(iridian): A lot of this content should be straight-up moved to UIComponent.
 
 export const skipPresentation = {};

packages/prophet/FalseProphet/FalseProphetPartitionConnection.js

@@ -223,7 +223,7 @@ export default class FalseProphetPartitionConnection extends PartitionConnection
           (command, queueIndex) => {
             purgedCommands = this._unconfirmedCommands.splice(queueIndex);
           });
-      _purgeAndRecomposeStories(this, purgedCommands, newCommands, "receiveCommand");
+      _purgeAndRecomposeStories(this, purgedCommands, newCommands || [], "receiveCommand");
       return commands;
     } catch (error) {
       throw this.wrapErrorEvent(error, `receiveCommand([${

packages/prophet/Scribe/ScribePartitionConnection.js

@@ -198,15 +198,15 @@ export default class ScribePartitionConnection extends PartitionConnection {
   // currently in the truth log write queue have been written, or
   // undefined if there are no pending truth writes.
   _triggerTruthLogWrites (lastTruthCommandId?: any) {
-    this._clampCommandQueueByTruthEvendIdEnd(lastTruthCommandId);
+    this._clampCommandQueueByTruthEventIdEnd(lastTruthCommandId);
     if (!this._truthLogInfo.writeQueue.length) return undefined;
     if (this._truthLogInfo.writeProcess) {
       return this._truthLogInfo.writeProcess.then(() => this._truthLogInfo.writeProcess);
     }
     return _triggerEventQueueWrites(this, this._truthLogInfo, this._writeTruths.bind(this));
   }
 
-  _clampCommandQueueByTruthEvendIdEnd (lastTruthCommandId?: any) {
+  _clampCommandQueueByTruthEventIdEnd (lastTruthCommandId?: any) {
     const deleteBegin = this._commandQueueInfo.eventIdBegin;
     if (!(deleteBegin < this._truthLogInfo.eventIdEnd)) return undefined;
     const commandIds = this._commandQueueInfo.commandIds;
@@ -223,12 +223,18 @@ export default class ScribePartitionConnection extends PartitionConnection {
       this._commandQueueInfo.eventIdBegin = this._commandQueueInfo.eventIdEnd =
           this._truthLogInfo.eventIdEnd;
     }
+    const wrap = new Error(`_clampCommandQueueByTruthEventIdEnd(${lastTruthCommandId})`);
     return !deletedIds.length ? undefined : thenChainEagerly(
         _deleteCommands(this, deleteBegin, deleteBegin + deletedIds.length, deletedIds),
         commands => commands,
         error => {
-          if (typeof error.conflictingCommandEventId !== "number") throw error;
-          this._reloadCommandQueue(error.conflictingCommandEventId);
+          if (typeof error.conflictingCommandEventId === "number") {
+            return this._reloadCommandQueue(error.conflictingCommandEventId);
+          }
+          throw this.wrapErrorEvent(error, wrap,
+              "\n\tdeleteBegin:", deleteBegin,
+              "\n\tdeleteBegin + len:", deleteBegin + deletedIds.length,
+              "\n\tdeletedIds:", deletedIds);
         });
   }
 

packages/prophet/Scribe/_databaseOps.js

@@ -92,7 +92,7 @@ export async function _initializeConnectionIndexedDB (connection: ScribePartitio
     connection._commandQueueInfo.commandIds = new Array(
         connection._commandQueueInfo.eventIdEnd - connection._commandQueueInfo.eventIdBegin);
   });
-  connection._clampCommandQueueByTruthEvendIdEnd();
+  connection._clampCommandQueueByTruthEventIdEnd();
   return this;
 
   function _loadEventId (entries, direction: ?"prev", target, eventIdTargetFieldName) {

packages/raem/VALK/Kuery.js

@@ -2,7 +2,6 @@ import { vRef } from "~/raem/ValaaReference";
 import type { VRef } from "~/raem/ValaaReference"; // eslint-disable-line no-duplicate-imports
 
 import beaumpify from "~/tools/beaumpify";
-import dumpify from "~/tools/dumpify";
 import inBrowser from "~/tools/inBrowser";
 import invariantify, { invariantifyArray, invariantifyNumber, invariantifyString,
     invariantifyObject } from "~/tools/invariantify";
@@ -11,6 +10,8 @@ import trivialClone from "~/tools/trivialClone";
 
 import { isHostRef, tryHostRef } from "./hostReference";
 
+const dumpify = require("~/tools/dumpify").default;
+
 /**
  * VALK - VAlaa Language for Kuerying
  * ==================================

packages/raem/VALK/packedField.js

@@ -4,11 +4,12 @@ import ValaaReference from "~/raem/ValaaReference";
 
 import type { FieldInfo } from "~/raem/state/FieldInfo";
 
-import dumpify from "~/tools/dumpify";
 import { invariantifyString } from "~/tools/invariantify";
 
 import { PackedHostValue, HostRef, tryHostRef } from "~/raem/VALK/hostReference";
 
+const dumpify = require("~/tools/dumpify").default;
+
 // PackedField is a packed, datatype for accessing reference fields lazily. Potentially expensive
 // operations like value elevations and sequence completions will only be performed when needed.
 

packages/raem/redux/middleware/validateEvent.js

@@ -1,5 +1,6 @@
 import wrapError from "~/tools/wrapError";
-import dumpify from "~/tools/dumpify";
+
+const dumpify = require("~/tools/dumpify").default;
 
 export default function createValidateEventMiddleware (validators, defaultVersion: string,
     fixedVersion?: string) {

packages/raem/tools/denormalized/collectFields.js

@@ -8,7 +8,8 @@ import { tryObjectTransient } from "~/raem/state/getObjectTransient";
 import { getTransientTypeName } from "~/raem/state/Transient";
 
 import wrapError from "~/tools/wrapError";
-import dumpify from "~/tools/dumpify";
+
+const dumpify = require("~/tools/dumpify").default;
 */
 
 /**