-
Notifications
You must be signed in to change notification settings - Fork 63
Telco Hub pattern docs #610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Telco Hub pattern docs #610
Conversation
|
🤖 Wed Nov 05 01:54:46 - The preview is ready at: |
6719327 to
848f16f
Compare
imiller0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice work @gaurav-nelson. Thank you!
I've added comments...
leo8a
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks @gaurav-nelson for this effort, it is looking good.
I've dropped comments below and suggestions for updating the content. Hope this helps.
848f16f to
39b4bdd
Compare
|
@leo8a: GitHub didn't allow me to request PR reviews from the following users: gaurav-nelson. Note that only validatedpatterns members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
leo8a
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of more nits I've found here and there, thanks @gaurav-nelson!
|
@leo8a: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
39b4bdd to
dd75414
Compare
dd75414 to
286b3db
Compare
| + | ||
| [source,terminal] | ||
| ---- | ||
| $ oc describe applications.argoproj.io telco-config -n telco-hub-pattern-hub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| $ oc describe applications.argoproj.io telco-config -n telco-hub-pattern-hub | |
| $ oc describe applications.argoproj.io hub-config -n telco-hub-pattern-hub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
telco-config doesn't exist in current implementation
-> oc describe applications.argoproj.io telco-config -n telco-hub-pattern-hub
Error from server (NotFound): applications.argoproj.io "telco-config" not found
| + | ||
| [source,terminal] | ||
| ---- | ||
| $ o$ oc describe applications.argoproj.io clusters policies -n telco-hub-pattern |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| $ o$ oc describe applications.argoproj.io clusters policies -n telco-hub-pattern | |
| $ oc describe applications.argoproj.io clusters policies -n telco-hub-pattern |
day0hero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
For https://issues.redhat.com/browse/TELCODOCS-953
Added initial documentation for the new Telco Hub pattern. Covers the overview, configuration, deployment, and management of the pattern. The content is based on https://github.com/validatedpatterns-sandbox/telco-hub-pattern/blob/main/docs/getting-started.md
Preview the docs at https://610--patternsdocs-pr.netlify.app/patterns/telco-hub/