fix: panic when evaluating IAM user rules #503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g it to catch nil cases. Signed-off-by: Matt Welke <matt.welke@spectrocloud.com>
dosubot
bot
added
size:XS
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #503 +/- ##
==========================================
- Coverage 72.00% 71.90% -0.11%
==========================================
Files 11 11
Lines 1143 1146 +3
==========================================
+ Hits 823 824 +1
- Misses 257 258 +1
- Partials 63 64 +1
Continue to review full report in Codecov by Sentry.
|
TylerGillson
approved these changes
Nov 13, 2024
mattwelke
pushed a commit
that referenced
this pull request
Nov 20, 2024
🤖 I have created a release *beep* *boop* --- ## [0.1.8](v0.1.7...v0.1.8) (2024-11-20) ### Features * support inline auth ([#501](#501)) ([1c2fd8a](1c2fd8a)) ### Bug Fixes * panic when evaluating IAM user rules ([#503](#503)) ([7ab45b6](7ab45b6)) ### Other * make reviewable ([#500](#500)) ([75c3305](75c3305)) * update renovate.json ([3b73e58](3b73e58)) * Update renovate.json ([ee977e6](ee977e6)) ### Dependency Updates * **deps:** update all non-major dependencies ([#498](#498)) ([17b6291](17b6291)) * **deps:** update all non-major dependencies ([#507](#507)) ([d8c0998](d8c0998)) * **deps:** update all non-major dependencies ([#508](#508)) ([977532f](977532f)) * **deps:** update all non-major dependencies ([#509](#509)) ([ab3d355](ab3d355)) * **deps:** update aws-sdk-go-v2 monorepo ([#465](#465)) ([92c4d1b](92c4d1b)) * **deps:** update aws-sdk-go-v2 monorepo ([#493](#493)) ([641afa8](641afa8)) * **deps:** update build digest to 3463b98 ([#506](#506)) ([2825241](2825241)) * **deps:** update build digest to 3840c9d ([#510](#510)) ([4d870be](4d870be)) * **deps:** update golang.org/x/exp digest to 2d47ceb ([#499](#499)) ([5ba6974](5ba6974)) * **deps:** update golang.org/x/exp digest to e7e105d ([#485](#485)) ([383ece0](383ece0)) * **deps:** update golang.org/x/exp digest to f66d83c ([#488](#488)) ([c8d8c69](c8d8c69)) * **deps:** update k8s.io/utils digest to 6fe5fd8 ([#505](#505)) ([84017e6](84017e6)) * **deps:** update kubernetes packages to v0.31.1 ([#490](#490)) ([2f7e19d](2f7e19d)) * **deps:** update kubernetes packages to v0.31.2 ([#492](#492)) ([42afaa7](42afaa7)) * **deps:** update module github.com/aws/aws-sdk-go-v2/service/ec2 to v1.184.0 ([#491](#491)) ([b84bfcc](b84bfcc)) * **deps:** update module github.com/aws/aws-sdk-go-v2/service/ec2 to v1.188.0 ([#504](#504)) ([43e420c](43e420c)) * **deps:** update module github.com/onsi/ginkgo/v2 to v2.20.2 ([#483](#483)) ([a42aedb](a42aedb)) * **deps:** update module github.com/onsi/ginkgo/v2 to v2.21.0 ([#495](#495)) ([8f4d37a](8f4d37a)) * **deps:** update module github.com/onsi/gomega to v1.34.2 ([#484](#484)) ([409bd7b](409bd7b)) * **deps:** update module github.com/onsi/gomega to v1.35.0 ([#496](#496)) ([fe9ead5](fe9ead5)) * **deps:** update module github.com/validator-labs/validator to v0.1.12 ([#486](#486)) ([5b6701c](5b6701c)) * **deps:** update module github.com/validator-labs/validator to v0.1.9 ([#477](#477)) ([2509b3c](2509b3c)) * **deps:** update module sigs.k8s.io/cluster-api to v1.8.2 ([#487](#487)) ([0ceab69](0ceab69)) * **deps:** update module sigs.k8s.io/cluster-api to v1.8.4 ([#489](#489)) ([78c5ec4](78c5ec4)) * **deps:** update module sigs.k8s.io/controller-runtime to v0.19.1 ([#494](#494)) ([3747e12](3747e12)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #502.
Description
Fixes the issue by checking for nil first during IAM rule evaluation.