Skip to content

fix: panic when evaluating IAM user rules #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2024
Merged

fix: panic when evaluating IAM user rules #503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build
Open in desktop
Submodule build updated 4 files
+1 −1 .github/workflows/golicenses.yaml
+1 −1 .github/workflows/gosec.yaml
+3 −3 .github/workflows/release.yaml
+3 −3 .github/workflows/test.yaml
4 changes: 4 additions & 0 deletions pkg/validators/iam/iam_validator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,6 +412,10 @@
}

for _, result := range simResults {
// Not all simulation results will have this field (ie. when service control policies are not used).
if result.OrganizationsDecisionDetail == nil {
continue

Check warning on line 417 in pkg/validators/iam/iam_validator.go

View check run for this annotation

Codecov / codecov/patch

pkg/validators/iam/iam_validator.go#L417 

Added line #L417 was not covered by tests
}
if !result.OrganizationsDecisionDetail.AllowedByOrganizations && result.EvalDecision != "allowed" {
// append SCP failure
scpFailures = append(scpFailures, fmt.Sprintf("Action: %s is denied due to an Organization level SCP policy for %s: %s", *result.EvalActionName, policySourceType, policySourceName))
Expand Down