fix: ensure ErrValidationFailed is returned for maas direct validation failures #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
mattwelke
approved these changes
Aug 20, 2024
TylerGillson
approved these changes
Aug 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #179 +/- ##
==========================================
+ Coverage 53.60% 53.61% +0.01%
==========================================
Files 44 44
Lines 6218 6220 +2
==========================================
+ Hits 3333 3335 +2
Misses 2056 2056
Partials 829 829
Continue to review full report in Codecov by Sentry.
|
TylerGillson
added a commit
that referenced
this pull request
Sep 3, 2024
🤖 I have created a release *beep* *boop* --- ## [0.1.3](v0.1.2...v0.1.3) (2024-09-03) ### Features * inline auth for MAAS ([#198](#198)) ([ed78617](ed78617)) * support Azure plugin community gallery image rule ([#181](#181)) ([3d20725](3d20725)) ### Bug Fixes * ensure ErrValidationFailed is returned for maas direct validation failures ([#179](#179)) ([0e0e7b9](0e0e7b9)) * handle validation errors, result count mismatch ([#204](#204)) ([a2ea08b](a2ea08b)) * only require docker, kind when provisioning kind cluster ([#180](#180)) ([1bbdb0e](1bbdb0e)) * remove duplicate maas base values from template ([#182](#182)) ([cfa39a8](cfa39a8)) * support `validator rules check -f config.yaml` without all plugins defined ([#191](#191)) ([6829834](6829834)) ### Other * cleanup comment ([#176](#176)) ([f371927](f371927)) ### Dependency Updates * **deps:** update anchore/sbom-action action to v0.17.2 ([#184](#184)) ([00d3a5c](00d3a5c)) * **deps:** update github.com/validator-labs/validator-plugin-maas digest to e903cc7 ([#175](#175)) ([09c3ad1](09c3ad1)) * **deps:** update golang.org/x/exp digest to 9b4947d ([#190](#190)) ([8c427e9](8c427e9)) * **deps:** update module github.com/canonical/gomaasclient to v0.7.0 ([#197](#197)) ([f43a5ba](f43a5ba)) * **deps:** update module github.com/validator-labs/validator to v0.1.8 ([#120](#120)) ([fe587c6](fe587c6)) * **deps:** update module github.com/vmware/govmomi to v0.42.0 ([#172](#172)) ([f0488c9](f0488c9)) ### Refactoring * move vsphere account under auth to match new plugin api ([#189](#189)) ([90352e1](90352e1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
N/A
Description
When running
validator rules check, we werent properly setting the validationSuccess variable (ok) to false.