Skip to content

Conversation

@TylerGillson
Copy link
Member

Issue

N/A

Description

  • Filter empty lines and comments from vCenter local file privileges
  • Skip KUBECONFIG check when updating passwords in direct mode

Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson TylerGillson requested a review from a team as a code owner September 4, 2024 15:39
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working labels Sep 4, 2024
ahmad-ibra
ahmad-ibra previously approved these changes Sep 4, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 4, 2024
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@codecov
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 19.23077% with 21 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/services/validator/vmware.go 31.25% 7 Missing and 4 partials ⚠️
pkg/services/validator/validator_service.go 0.00% 10 Missing ⚠️
@@            Coverage Diff             @@
##             main     #207      +/-   ##
==========================================
- Coverage   53.38%   53.33%   -0.06%     
==========================================
  Files          45       45              
  Lines        6247     6253       +6     
==========================================
  Hits         3335     3335              
- Misses       2069     2073       +4     
- Partials      843      845       +2     
Files with missing lines Coverage Δ
pkg/services/validator/validator_service.go 46.13% <0.00%> (-0.33%) ⬇️
pkg/services/validator/vmware.go 40.42% <31.25%> (-0.19%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f337321...d04888c. Read the comment docs.

@TylerGillson TylerGillson merged commit 29f1db4 into main Sep 4, 2024
@TylerGillson TylerGillson deleted the fix/vsphere-local-file branch September 4, 2024 17:27
TylerGillson added a commit that referenced this pull request Sep 4, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.1.4](v0.1.3...v0.1.4)
(2024-09-04)


### Bug Fixes

* filter vCenter local file privileges properly, skip KUBECONFIG check
when updating passwords in direct mode
([#207](#207))
([29f1db4](29f1db4))


### Dependency Updates

* **deps:** update module github.com/validator-labs/validator-plugin-oci
to v0.3.3
([#209](#209))
([e553967](e553967))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants