Skip to content

Conversation

@Yury-Fridlyand
Copy link
Contributor

  • Bump submodule (include Migrate C# client valkey-glide#4532)
  • Update gitignore
  • Update gitmodules - previous version was forcing ssh, new version preserves protocol a user prefers

@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner August 25, 2025 17:18
Copy link

@jamesx-improving jamesx-improving left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yury-Fridlyand
Copy link
Contributor Author

@jbrinkman could be CI failure related to valkey-io/valkey-glide#4630?

Copy link
Collaborator

@edlng edlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! But tests are failing

Copy link
Collaborator

@jbrinkman jbrinkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@edlng
Copy link
Collaborator

edlng commented Aug 29, 2025

For #63 we might want to bump it up a bit more so we can run tests on 9.0.0 rc1

Yury-Fridlyand and others added 2 commits September 3, 2025 12:11
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: ort-bot <valkey-glide@lists.valkey.io>
Co-authored-by: ort-bot <valkey-glide@lists.valkey.io>
@jbrinkman jbrinkman force-pushed the yuryf/bump-submodule branch from 8a66b44 to bf7eb82 Compare September 3, 2025 16:11
Signed-off-by: jbrinkman <joe.brinkman@improving.com>
@jbrinkman
Copy link
Collaborator

I've bumped this to the latest version so we can include the script fix for the benchmarks.

Signed-off-by: jbrinkman <joe.brinkman@improving.com>
Signed-off-by: jbrinkman <joe.brinkman@improving.com>
Signed-off-by: jbrinkman <joe.brinkman@improving.com>
Signed-off-by: jbrinkman <joe.brinkman@improving.com>
Signed-off-by: jbrinkman <joe.brinkman@improving.com>
Signed-off-by: jbrinkman <joe.brinkman@improving.com>
Signed-off-by: jbrinkman <joe.brinkman@improving.com>
Signed-off-by: jbrinkman <joe.brinkman@improving.com>
Signed-off-by: jbrinkman <joe.brinkman@improving.com>
Signed-off-by: jbrinkman <joe.brinkman@improving.com>
…alkey-glide submodule

Signed-off-by: jbrinkman <joe.brinkman@improving.com>
Signed-off-by: jbrinkman <joe.brinkman@improving.com>
Signed-off-by: jbrinkman <joe.brinkman@improving.com>
…dule

Signed-off-by: jbrinkman <joe.brinkman@improving.com>
Signed-off-by: jbrinkman <joe.brinkman@improving.com>
Signed-off-by: jbrinkman <joe.brinkman@improving.com>
@jbrinkman jbrinkman merged commit 380cd28 into main Sep 3, 2025
12 checks passed
@jbrinkman jbrinkman deleted the yuryf/bump-submodule branch September 3, 2025 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants