Add first ValkeyConnection unit test #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-fowler
reviewed
Apr 6, 2025
Collaborator
adam-fowler
left a comment
adam-fowler
left a comment
There was a problem hiding this comment.
One minor thing. Otherwise looks good
| } | ||
|
|
||
| private static func _setupChannel(_ channel: any Channel, configuration: ValkeyClientConfiguration, logger: Logger) throws -> ValkeyConnection { | ||
| channel.eventLoop.assertInEventLoop() |
Collaborator
There was a problem hiding this comment.
This code is the same as in _makeClient() which sets up the bootstrap. Maybe use the same function in _makeClient.
fabianfett
force-pushed
the
ff-first-connection-unit-test
branch
from
23ae72a to
882ec76
Compare
adam-fowler
approved these changes
Apr 6, 2025
adam-fowler
pushed a commit
that referenced
this pull request
Jul 11, 2025
adam-fowler
pushed a commit
that referenced
this pull request
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.