Skip to content

Conversation

@philippzagar
Copy link

When using CLIENT TRACKING with multiple prefixes, the generated Valkey command has invalid syntax.

The current implementation works fine for a single prefix, but fails with multiple prefixes. Valkey expects the format PREFIX prefix1 PREFIX prefix2 (each prefix needs its own PREFIX keyword), which causes a syntax error with our current approach.

See: valkey.io/commands/client-tracking/

@philippzagar philippzagar force-pushed the p-zagar/enable-multiple-prefixes-client-tracking branch from f26e5b4 to 15c7feb Compare December 2, 2025 14:19
Signed-off-by: Philipp Zagar <p_zagar@apple.com>
@philippzagar philippzagar force-pushed the p-zagar/enable-multiple-prefixes-client-tracking branch from 15c7feb to f16d8d4 Compare December 2, 2025 14:20
@philippzagar
Copy link
Author

@adam-fowler @fabianfett Please approve the CI and review the PR once you have the chance

@adam-fowler
Copy link
Collaborator

This won't be the fix. You are editing generated files. Your changes will get overwritten the next time we run the code generator.

There is a chance this is a general issue with arrays and prefixes. I will investigate

@philippzagar
Copy link
Author

philippzagar commented Dec 2, 2025

You are editing generated files

Totally didn't notice that, thanks!

general issue with arrays and prefixes. I will investigate

Yes, seems like there is an issue in the generator then.
Feel free to use the tests that I wrote for this specific CLIENT TRACKING behavior in your fix then.

@adam-fowler
Copy link
Collaborator

Yes, seems like there is an issue in the generator then.

I found a new tag in the json model files multiple_token. It looks like this indicates arrays with a token being rendered TOKEN entry1 TOKEN entry2 ....

@philippzagar
Copy link
Author

Yes, seems like there is an issue in the generator then.

I found a new tag in the json model files multiple_token. It looks like this indicates arrays with a token being rendered TOKEN entry1 TOKEN entry2 ....

Great! Will you put up a PR for the generator that respects this?

@adam-fowler
Copy link
Collaborator

#269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants