Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr2058 #2074

Closed
wants to merge 2 commits into from
Closed

Pr2058 #2074

wants to merge 2 commits into from

Conversation

artemvfrolov
Copy link
Contributor

@artemvfrolov artemvfrolov commented Jun 15, 2017

issue #2058
time picker

checking result:

questions:
#2036 "ngModelChange exists?"
#1973 "(change) working only when the input is directly changed"
#1935
#1271 "after invalid value, if we click on Chevron, error class not change"
#1124
#793

fixed:
#1981
#1672
#1539
#1007

issue:
#1957 "on seconds field arrows not working, validate not working too"
#1253
#962
#173

"in [meridian] when we change meridian, time in input don't change, and when we incrementing value, it incorrect"

"if we want to enter input value, value is not set, if we clicking on chevron, we have set default value, after that we trying set value again, value is not set, if we trying set invalid value, value is not set, but if we after that trying set valid value again, value is set."

@codecov
Copy link

codecov bot commented Jun 15, 2017

Codecov Report

Merging #2074 into development will decrease coverage by 41.22%.
The diff coverage is 86.05%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development   #2074       +/-   ##
===============================================
- Coverage        87.13%   45.9%   -41.23%     
===============================================
  Files               85      94        +9     
  Lines             2262    2577      +315     
  Branches           292     339       +47     
===============================================
- Hits              1971    1183      -788     
- Misses             188    1385     +1197     
+ Partials           103       9       -94
Impacted Files Coverage Δ
src/timepicker/reducer/timepicker.actions.ts 100% <100%> (ø)
src/timepicker/timepicker.config.ts 100% <100%> (ø)
src/timepicker/timepicker.component.ts 100% <100%> (ø)
src/timepicker/reducer/timepicker.store.ts 100% <100%> (ø)
src/mini-ngrx/store.class.ts 100% <100%> (ø)
src/timepicker/timepicker-controls.util.ts 27.5% <27.5%> (ø)
src/timepicker/timepicker.utils.ts 77.5% <77.5%> (ø)
src/mini-ngrx/state.class.ts 84.61% <84.61%> (ø)
src/timepicker/reducer/timepicker.reducer.ts 93.75% <93.75%> (ø)
src/utils/triggers.ts 10.71% <0%> (-85.72%) ⬇️
... and 68 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1eafa8c...e283735. Read the comment docs.

@valorkin valorkin closed this Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants