Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timepicker without chevron doesn't work with bootstrap v4 #1539

Closed
Klinton90 opened this issue Jan 23, 2017 · 2 comments · Fixed by #2058
Closed

Timepicker without chevron doesn't work with bootstrap v4 #1539

Klinton90 opened this issue Jan 23, 2017 · 2 comments · Fixed by #2058
Labels
comp(timepicker) effort1: easy (hours) enhancement

Comments

@Klinton90
Copy link

First of all, thank you for your great job.

In source code of TimePicker you apply .hidden class to chevron row to make them hidden. That css class doesn't exist in bootstrap (anymore?).
Probably you can change code to *ngIf instead.
@valorkin
Copy link
Member

@Klinton90 thank you for kind words, I was trying to avoid heavy things like *ngIf
but most probably I will end up doing this
BTW it is good reason for small PR ;)

@Klinton90
Copy link
Author

Have to learn how to use webpack. Don't have time for that during the week. Will play with that on weekend. Another option will be defining Component level class instead of *ngIf

@artemvfrolov artemvfrolov mentioned this issue Jun 15, 2017
Closed
@valorkin valorkin mentioned this issue Jun 19, 2017
Merged
valorkin added a commit that referenced this issue Jul 19, 2017
@valorkin
feat(timepicker): new timepicker implementation (#2058)
4a37406 
fixes #2036
fixes #1981 ( + min max demo )
fixes #1973
close #1957 ( + seconds demo )
fixes #1935
fixes #1672
feat #1007 added keyboard and mousewheel support
fixes #962
fixes #793
fixes #173
fixes #1271 added custom validation demo
fixes #1539 bs4
fixes #1253 if input is invalid

* feat(timepicker): new timepicker implementation

* feat(timepicker): new timepicker implementation testing

* chore(timepicker): removed old timepicker implementation

* chore(mini-ngrx): added ngrx licence

* fix(timepicker): fix seconds

* fix(timepicker): fix custom validation demo

* fix(tests): fix tests & aot errors

* fix(timepicker): min max restrictions

* fix(timepicker): min max checks

* feat(timepicker): add inputs validation (#2187)

* feat(timepicker): add inputs validation

* fix(timepicker): add isPM support

* feat(timepicker): add isValid output

* feat(timepicker): added test plan (#2127)

* fix(timepicker): fix ngModelChange demo

* fix(test): fix unit tests

* docs(timepicker): fix docs conflict, add isValid description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp(timepicker) effort1: easy (hours) enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(timepicker): new timepicker implementation valor-software/ngx-bootstrap
3 participants
@valorkin @Klinton90 @SergeyKuryatnick