Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timepicker's invalidHours/invalidMinutes does not apply to inputs #1271

Closed
ebakunin opened this issue Nov 28, 2016 · 2 comments · Fixed by #2058
Closed

Timepicker's invalidHours/invalidMinutes does not apply to inputs #1271

ebakunin opened this issue Nov 28, 2016 · 2 comments · Fixed by #2058
Labels
comp(timepicker)

Comments

@ebakunin
Copy link

ebakunin commented Nov 28, 2016 •
edited

In timepicker, an invalid value is marked in the surrounding <td> elements. However, the input still remains .ng-valid.

For example, add a minimum value to a timepicker. Type a value in the hour field that is before the minimum time (do not use the arrow icons). this.invalidHours will be set to true and .has-error will be applied to the surrounding <td>. However, ngClassValid will remain true.

Can this be fixed? Thanks.
@valorkin
Copy link
Member

need to add hack in with ngModelValidation

@artemvfrolov artemvfrolov mentioned this issue Jun 15, 2017
Closed
@valorkin valorkin mentioned this issue Jun 19, 2017
Merged
@valorkin
Copy link
Member

unfortunately, I don't see a way for changing validation status inside of timepicker
so we will provide custom validation demo

valorkin added a commit that referenced this issue Jul 19, 2017
@valorkin
feat(timepicker): new timepicker implementation (#2058)
4a37406 
fixes #2036
fixes #1981 ( + min max demo )
fixes #1973
close #1957 ( + seconds demo )
fixes #1935
fixes #1672
feat #1007 added keyboard and mousewheel support
fixes #962
fixes #793
fixes #173
fixes #1271 added custom validation demo
fixes #1539 bs4
fixes #1253 if input is invalid

* feat(timepicker): new timepicker implementation

* feat(timepicker): new timepicker implementation testing

* chore(timepicker): removed old timepicker implementation

* chore(mini-ngrx): added ngrx licence

* fix(timepicker): fix seconds

* fix(timepicker): fix custom validation demo

* fix(tests): fix tests & aot errors

* fix(timepicker): min max restrictions

* fix(timepicker): min max checks

* feat(timepicker): add inputs validation (#2187)

* feat(timepicker): add inputs validation

* fix(timepicker): add isPM support

* feat(timepicker): add isValid output

* feat(timepicker): added test plan (#2127)

* fix(timepicker): fix ngModelChange demo

* fix(test): fix unit tests

* docs(timepicker): fix docs conflict, add isValid description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp(timepicker)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(timepicker): new timepicker implementation valor-software/ngx-bootstrap
2 participants
@valorkin @ebakunin