Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timepicker spinner click won't trigger change function #962

Closed
linnobita opened this issue Sep 13, 2016 · 2 comments · Fixed by #2058
Closed

Timepicker spinner click won't trigger change function #962

linnobita opened this issue Sep 13, 2016 · 2 comments · Fixed by #2058

Comments

@linnobita
Copy link

linnobita commented Sep 13, 2016

Here is my code:

<div class="operation-time col-sm-6">
    <div class="modal-form-label">Open Time:</div>
    <timepicker [(ngModel)]="selectedStartTime" (change)="startTimeChanged()"></timepicker>
</div>
<div class="operation-time col-sm-6">
    <div class="modal-form-label">Close Time:</div>
   <timepicker [(ngModel)]="selectedEndTime" [min]="minEndTime"></timepicker>
</div>

I need to change the minEndTime value when the start time has been changed. When I changed the time from the input, it works perfectly. But when I clicked on the spinner to change the start time, the startTimeChanged() was not called. And then I checked the demo, it seems there is no way to trigger change function while using the spinners. Will there be a workaround or something?

@temokallc
Copy link

I need this feature as well

@kurtiev
Copy link

kurtiev commented Apr 21, 2017

Also need this feature

@artemvfrolov artemvfrolov mentioned this issue Jun 15, 2017
valorkin added a commit that referenced this issue Jul 19, 2017
fixes #2036
fixes #1981 ( + min max demo )
fixes #1973
close #1957 ( + seconds demo )
fixes #1935
fixes #1672
feat #1007 added keyboard and mousewheel support
fixes #962
fixes #793
fixes #173
fixes #1271 added custom validation demo
fixes #1539 bs4
fixes #1253 if input is invalid

* feat(timepicker): new timepicker implementation

* feat(timepicker): new timepicker implementation testing

* chore(timepicker): removed old timepicker implementation

* chore(mini-ngrx): added ngrx licence

* fix(timepicker): fix seconds

* fix(timepicker): fix custom validation demo

* fix(tests): fix tests & aot errors

* fix(timepicker): min max restrictions

* fix(timepicker): min max checks

* feat(timepicker): add inputs validation (#2187)

* feat(timepicker): add inputs validation

* fix(timepicker): add isPM support

* feat(timepicker): add isValid output

* feat(timepicker): added test plan (#2127)

* fix(timepicker): fix ngModelChange demo

* fix(test): fix unit tests

* docs(timepicker): fix docs conflict, add isValid description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants