Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(timepicker): spinner doesn't fire change event #173

Closed
leeyikjiun opened this issue Feb 11, 2016 · 3 comments · Fixed by #2058
Closed

fix(timepicker): spinner doesn't fire change event #173

leeyikjiun opened this issue Feb 11, 2016 · 3 comments · Fixed by #2058
Labels
comp(timepicker) issue

Comments

@leeyikjiun
Copy link

The binding for timepicker spinner works but is there a way to get it to fire a change event?
@valorkin
Copy link
Member

it should bind to ngModel
is it mutating Date object?

@leeyikjiun
Copy link
Author

The Date object is mutated but I'm trying to inform another Component that the Date object has changed. Sadly, the ngOnChanges method only fires on reference change and not mutation. Hence, I want to trigger a EventEmitter from the "onChange" method of spinner.

I searched online and they said to implement my own DoCheck but the documentation is very limited.

I'm fairly new to Angular2, what's the right way to do what I mentioned above?

@valorkin valorkin changed the title timepicker spinner doesn't fire change event fix(timepicker): spinner doesn't fire change event Mar 31, 2016
@temokallc
Copy link

Has a workaround been identified for this, I need this ability as well.

@artemvfrolov artemvfrolov mentioned this issue Jun 15, 2017
Closed
@valorkin valorkin mentioned this issue Jun 19, 2017
Merged
valorkin added a commit that referenced this issue Jul 19, 2017
@valorkin
feat(timepicker): new timepicker implementation (#2058)
4a37406 
fixes #2036
fixes #1981 ( + min max demo )
fixes #1973
close #1957 ( + seconds demo )
fixes #1935
fixes #1672
feat #1007 added keyboard and mousewheel support
fixes #962
fixes #793
fixes #173
fixes #1271 added custom validation demo
fixes #1539 bs4
fixes #1253 if input is invalid

* feat(timepicker): new timepicker implementation

* feat(timepicker): new timepicker implementation testing

* chore(timepicker): removed old timepicker implementation

* chore(mini-ngrx): added ngrx licence

* fix(timepicker): fix seconds

* fix(timepicker): fix custom validation demo

* fix(tests): fix tests & aot errors

* fix(timepicker): min max restrictions

* fix(timepicker): min max checks

* feat(timepicker): add inputs validation (#2187)

* feat(timepicker): add inputs validation

* fix(timepicker): add isPM support

* feat(timepicker): add isValid output

* feat(timepicker): added test plan (#2127)

* fix(timepicker): fix ngModelChange demo

* fix(test): fix unit tests

* docs(timepicker): fix docs conflict, add isValid description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp(timepicker) issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(timepicker): new timepicker implementation valor-software/ngx-bootstrap
2 participants
@valorkin @leeyikjiun