Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(timepicker): add inputs validation #2187

Merged
merged 3 commits into from
Jul 14, 2017

Conversation

IlyaSurmay
Copy link
Contributor

added validation to inputs

@IlyaSurmay IlyaSurmay requested a review from valorkin July 13, 2017 12:23
@codecov
Copy link

codecov bot commented Jul 13, 2017

Codecov Report

Merging #2187 into feat-timepicker will decrease coverage by 0.79%.
The diff coverage is 50%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           feat-timepicker    #2187     +/-   ##
==================================================
- Coverage            86.63%   85.83%   -0.8%     
==================================================
  Files                   94       94             
  Lines                 2656     2619     -37     
  Branches               356      350      -6     
==================================================
- Hits                  2301     2248     -53     
- Misses                 231      241     +10     
- Partials               124      130      +6
Impacted Files Coverage Δ
src/timepicker/timepicker-controls.util.ts 32.81% <0%> (-1.57%) ⬇️
src/timepicker/timepicker.utils.ts 74.02% <66.66%> (-9.54%) ⬇️
src/timepicker/timepicker.component.ts 98.11% <87.5%> (-0.89%) ⬇️
src/timepicker/reducer/timepicker.reducer.ts 60% <0%> (-10%) ⬇️
src/tabs/tabset.component.ts 84.12% <0%> (-6.35%) ⬇️
src/timepicker/reducer/timepicker.actions.ts 95.45% <0%> (-4.55%) ⬇️
src/accordion/accordion.component.ts 95% <0%> (-1.78%) ⬇️
src/buttons/button-radio.directive.ts 97.29% <0%> (+0.52%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21e48e5...c31e975. Read the comment docs.

@valorkin valorkin merged commit 7e80486 into feat-timepicker Jul 14, 2017
@valorkin valorkin deleted the feat-timepicker-inputs-validation branch July 14, 2017 08:12
valorkin added a commit that referenced this pull request Jul 19, 2017
fixes #2036
fixes #1981 ( + min max demo )
fixes #1973
close #1957 ( + seconds demo )
fixes #1935
fixes #1672
feat #1007 added keyboard and mousewheel support
fixes #962
fixes #793
fixes #173
fixes #1271 added custom validation demo
fixes #1539 bs4
fixes #1253 if input is invalid

* feat(timepicker): new timepicker implementation

* feat(timepicker): new timepicker implementation testing

* chore(timepicker): removed old timepicker implementation

* chore(mini-ngrx): added ngrx licence

* fix(timepicker): fix seconds

* fix(timepicker): fix custom validation demo

* fix(tests): fix tests & aot errors

* fix(timepicker): min max restrictions

* fix(timepicker): min max checks

* feat(timepicker): add inputs validation (#2187)

* feat(timepicker): add inputs validation

* fix(timepicker): add isPM support

* feat(timepicker): add isValid output

* feat(timepicker): added test plan (#2127)

* fix(timepicker): fix ngModelChange demo

* fix(test): fix unit tests

* docs(timepicker): fix docs conflict, add isValid description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants