Skip to content
This repository was archived by the owner on May 29, 2025. It is now read-only.

Conversation

@OjusWiZard
Copy link
Member

@OjusWiZard OjusWiZard commented Oct 22, 2024

Allow skipping user prompts in the QS

@jmoreira-valory
Copy link
Collaborator

If it's not a lot of work, can we consider having the negate environment variable instead? UNATTENDED ?

@OjusWiZard
Copy link
Member Author

OjusWiZard commented Oct 22, 2024

@jmoreira-valory I started with that, but then went with ATTENDED to avoid double negation when checking if it's "not unattended". I believe it's more understandable to say "attended". More explained here

@jmoreira-valory
Copy link
Collaborator

jmoreira-valory commented Oct 23, 2024

@jmoreira-valory I started with that, but then went with ATTENDED to avoid double negation when checking if it's "not unattended". I believe it's more understandable to say "attended". More explained here

@OjusWiZard Yes you are absolutely right about confusing conditionals. However, the term "unattended installation" is a quite common accepted term in software deployment processes, that's why I suggested it. Also there is a bit unmatching the flag --unattended and the environment variable ATTENDED. Not mandatory to change it, though, I let you decide what's the best option in this case. (I accept the PR anyways to avoid delay merging it.)

@OjusWiZard OjusWiZard changed the title Feat: --unattended to skip user prompts Feat: --attended=false to skip user prompts Oct 23, 2024
@0xArdi
Copy link
Contributor

0xArdi commented Oct 23, 2024

@OjusWiZard please rebase to develop. Changes look good.

Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
@OjusWiZard OjusWiZard changed the base branch from main to develop October 24, 2024 08:09
@0xArdi 0xArdi merged commit c685ad7 into valory-xyz:develop Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants