Skip to content

Conversation

@CunliangGeng
Copy link
Member

No description provided.

@CunliangGeng CunliangGeng requested review from bartvanb and Copilot July 1, 2025 10:09
@CunliangGeng CunliangGeng self-assigned this Jul 1, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the sleep function by breaking the single sleep call into a per-second loop and adding progress logging.

  • Replaces time.sleep(seconds) with a loop that logs elapsed seconds.
  • Adds “start” and “completed” log messages around the sleep loop.
Comments suppressed due to low confidence (2)

v6-session-basics/partial.py:46

  • There are no tests covering the new logging behavior; consider adding unit tests that mock time.sleep and verify that info is called with the expected progress messages.
    info(f"Starting sleep task for {seconds} seconds")

v6-session-basics/partial.py:45

  • Add or update the function docstring to describe the new per-second progress logging behavior, including start, progress, and completion messages.
def sleep(seconds: int) -> dict:

@frankcorneliusmartin frankcorneliusmartin merged commit 3b2836d into main Jul 1, 2025
@frankcorneliusmartin frankcorneliusmartin deleted the add_long_time_logging branch July 1, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants