Skip to content

make stacktrace optional #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2019
Merged

make stacktrace optional #147

merged 1 commit into from
Oct 14, 2019

Conversation

@tanner0101
Copy link
Member

@tanner0101 tanner0101 commented Oct 14, 2019

Fixes #146

@tanner0101 tanner0101 added the bug Something isn't working label Oct 14, 2019
@tanner0101
Copy link
Member Author

tanner0101 commented Oct 14, 2019

Unfortunately Swift isn't allowing me to add any deprecation for stackTrace: [String]. However, since this really should have been stackTrace: [String]? in the first place, I think this should be merged.

Usually stackTrace would be accessed by casting the error to Debuggable first. It seems unlikely that this property would be accessed commonly on PostgresError directly.

@tanner0101 tanner0101 mentioned this pull request Oct 14, 2019
Closed
@tanner0101 tanner0101 merged commit 69ccf32 into 1 Oct 14, 2019
@tanner0101 tanner0101 deleted the tn-stacktrace-optional branch October 14, 2019 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tanner0101