Skip to content

Conversation

@gwynne
Copy link
Member

@gwynne gwynne commented Nov 30, 2025

When generating a string representation of PostgresNumeric values, we were misinterpreting the weight value for values with very small fractional parts. This caused decoding Decimals to return values with insufficient leading zeroes. Thanks to @patchthecode for reporting this issue!

… misinterpreting the weight value for values with very small fractional parts. This caused decoding as Decimal to return incorrect values. Thanks to @patchthecode for reporting this issue!
@gwynne gwynne requested a review from fabianfett November 30, 2025 17:26
@gwynne gwynne added bug Something isn't working semver-patch No public API change. labels Nov 30, 2025
@codecov
Copy link

codecov bot commented Nov 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.05%. Comparing base (db1eae1) to head (5ed090e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #603      +/-   ##
==========================================
- Coverage   75.11%   75.05%   -0.06%     
==========================================
  Files         132      132              
  Lines        9532     9534       +2     
==========================================
- Hits         7160     7156       -4     
- Misses       2372     2378       +6     
Files with missing lines Coverage Δ
...ources/PostgresNIO/Data/PostgresData+Numeric.swift 86.48% <100.00%> (+0.14%) ⬆️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fabianfett fabianfett merged commit 78114d4 into main Dec 1, 2025
10 checks passed
@fabianfett fabianfett deleted the fix-numeric-interpretation-with-lots-of-zeroes branch December 1, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working semver-patch No public API change.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants