Skip to content

Adopt NonisolatedNonsendingByDefault #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fabianfett merged 2 commits into from
Dec 4, 2025
Merged

Adopt NonisolatedNonsendingByDefault #604

fabianfett merged 2 commits into from
Dec 4, 2025
+54 −7

Conversation

@fabianfett
Copy link
Collaborator

@fabianfett fabianfett commented Dec 4, 2025 •
edited
Loading

@fabianfett fabianfett requested a review from gwynne as a code owner December 4, 2025 10:13
@fabianfett fabianfett mentioned this pull request Dec 4, 2025
Open
@codecov
Copy link

codecov bot commented Dec 4, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.61%. Comparing base (4db2fde) to head (2995ac7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #604      +/-   ##
==========================================
+ Coverage   75.42%   75.61%   +0.19%     
==========================================
  Files         134      134              
  Lines        9887     9912      +25     
==========================================
+ Hits         7457     7495      +38     
+ Misses       2430     2417      -13
Files with missing lines Coverage Δ
Sources/ConnectionPoolModule/ConnectionPool.swift 94.81% <100.00%> (ø)
...PostgresNIO/New/PostgresNotificationSequence.swift 100.00% <100.00%> (ø)
Sources/PostgresNIO/New/PostgresRowSequence.swift 92.95% <100.00%> (+2.95%) ⬆️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

FranzBusch
FranzBusch reviewed Dec 4, 2025
View reviewed changes
Copy link
Contributor

@FranzBusch FranzBusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gwynne
Copy link
Member

gwynne commented Dec 4, 2025

WTB fix for 6.1 build.

@fabianfett
Copy link
Collaborator Author

fabianfett commented Dec 4, 2025

@gwynne 6.1 has been fixed

@fabianfett fabianfett added the semver-minor Adds new public API. label Dec 4, 2025
@fabianfett fabianfett merged commit 9217854 into vapor:main Dec 4, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gwynne gwynne gwynne approved these changes

+1 more reviewer

@FranzBusch FranzBusch FranzBusch left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

semver-minor Adds new public API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fabianfett @gwynne @FranzBusch