Fixes I needed to make the build process work on Windows #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Change Else If -> ElseIf per <https://stackoverflow.com/questions/38439170/elseif-vs-else-if> This caused a syntax error <vba-blocks#46> 2) Fix the arithmetics dealing with the arguments count
|
@timhall glad to see you active on the project again! Could you take a look at this PR? |
|
Thanks! So sorry for the delay, merged in 9eeb46f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to follow the steps outlined at https://github.com/vba-blocks/vba-blocks#development I had two problems (first I installed the wrong version of yarn, then I stumbled upon the same problem as Senipah in #46).
I didn't get this working for my own project yet (that will need more fixes), but thought I'd share what I have so far.
How do I run the tests by the way? Just
yarn test?