git/commits: Log failed Git commands #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit: $ ./git-validation -run DCO -range HEAD^^..foo 2017/03/21 13:00:30 exit status 128 With this commit: $ ./git-validation -run DCO -range HEAD^^..foo ERRO[0000] [git] cmd: "git --no-pager log --no-merges --pretty=format:%H HEAD^^..foo" 2017/03/21 13:16:43 exit status 128 You can get similar output with -D, but folks are unlikely to set that in production. With the new error logs, Travis output and similar is more likely to contain some useful information. Signed-off-by: W. Trevor King <wking@tremily.us>
Owner
|
yeah fair. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit:
With this commit:
You can get similar output with
-D, but folks are unlikely to set that in production. With the new error logs, Travis output and similar is more likely to contain some useful information.