Feature/vcmi map format2 #200
Conversation
| "dwellingUpLvl7": { "id" : 43, "upgrades" : "dwellingLvl7" } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Interesting solution.
Doesn't this 'faction' show up in pregame or RMG by any chance?
There was a problem hiding this comment.
No. It will be used in engine only for resolving building id for random town (and loaded explicitly - no include to gameconfig.json). Everything else is for map editor.
There was a problem hiding this comment.
Even in map editor this file loaded to special object outside faction list. However format of this file (and special object type) equals normal faction.
ArseniyShestakov
force-pushed
the
develop
branch
from
efb5f8e to
4240eca
Compare
alexvins
force-pushed
the
feature/VCMIMapFormat2
branch
from
c9e8167 to
92648d6
Compare
|
Feature freeze for this branch. |
alexvins
force-pushed
the
feature/VCMIMapFormat2
branch
from
3ee9c4e to
d1f4752
Compare
alexvins
force-pushed
the
feature/VCMIMapFormat2
branch
from
3edbeaa to
7478303
Compare
|
All commits combined |
alexvins
force-pushed
the
feature/VCMIMapFormat2
branch
from
7478303 to
1ca1645
Compare
alexvins
force-pushed
the
feature/VCMIMapFormat2
branch
from
affdb04 to
2b002b5
Compare
alexvins
force-pushed
the
feature/VCMIMapFormat2
branch
2 times, most recently
from
0b3ebd0 to
41ff98f
Compare
|
So the first interesting bug found when testing loading of VCMI maps: currently heroes that should be spawned inside town appear two tiles in the right. Sometimes on blocked terrain. |
|
Little correction on heroes issue: this is probably editor / map conversion problem. |
|
So there is one small, but real issue that could would be nice to fix in this branch or ASAP once it merged. Currently if there is H3M and VCMI map with the same filename only VCMI version will be displayed in UI. |
|
Also critical issue found: once map is converted by editor "Event" objects not passable for player. UPD: Only occur when approach Event from top so likely some issue with visitability rules. |
|
@ArseniyShestakov To allow H3M and VCMI map with same name, we need to identify map by resourceId in all places. |
|
I don't think it's fix it sadly. Event still not passable from top. |
alexvins
force-pushed
the
feature/VCMIMapFormat2
branch
from
bb00f2d to
b933dcb
Compare
|
Fixed now. |
|
Now hero misplaced one tile to the left. Just in case I tested it with latest editor too. So it's not map conversion problem. |
alexvins
force-pushed
the
feature/VCMIMapFormat2
branch
from
9e7267e to
457a896
Compare
|
Should be fixed |
|
Yep fixed now. |
|
So I'll leave comment to explain why this is to be merged now since I talked with @alexvins about that already. Personally I wish to not merge anything that I can't fully test on my own, but this one was ready for quite some time and it's require massive amount of testing and messing with editor. I did fair a bit of it, but I expect there might be still plenty of things I missed. So I think we'll benefit from merging it as it's now and then let everyone else to mess with editor and the game to help us find what's could possible break. |
* Hero portrait serialization * Fix town spells serialization * Added support for float exponential part in Json * Added support for int64 in Json * Added basic Hero definitions serialization * Added rumors serialization * Advanced player info serialization. * Added Disposed heroes serialization, (!) not covered with tests yet * Added Local event serialization * Added Pandoras box serialization * Added Seer hut reward serialization * Added CQuest serialization * Added API for map object instance names serialization. * Added random dwelling options serialization * Advanced town options serialization * Advanced hero options serialization * More map format tests * A lot of fixes, cleanup and refactoring
alexvins
force-pushed
the
feature/VCMIMapFormat2
branch
from
25d7cc2 to
a85b4cf
Compare
To be done later: