Implementing hero battle window #222
Conversation
Allow to check battle enemy hero details + adding max spell points to available data
dydzio0614
force-pushed
the
HeroBattleWindow
branch
from
b4de41c to
f621ef4
Compare
|
Btw I agree with @DjWarmonger that we don't want to leak maximal mana outside of battle. |
| @@ -273,6 +273,16 @@ bool CGameInfoCallback::getHeroInfo(const CGObjectInstance * hero, InfoAboutHero | |||
|
|
|||
| bool accessFlag = hasAccess(h->tempOwner); | |||
|
|
|||
| if (!accessFlag && gs->curB) //if it's battle we can get enemy hero full data | |||
There was a problem hiding this comment.
Fact that some battle is going is not enough to provide info like that.
What I think would even better is to move this check into CBattleInfoEssentials callback and name it like "CBattleInfoEssentials::playerHasAccessToHeroInfo".
Then in this case it's would be:
if (!accessFlag && gs->curB)
accessFlag = gs->curB->playerHasAccessToHeroInfo(player, h);
| @@ -282,6 +292,9 @@ bool CGameInfoCallback::getHeroInfo(const CGObjectInstance * hero, InfoAboutHero | |||
|
|
|||
| dest.initFromHero(h, accessFlag); | |||
|
|
|||
| if (accessFlag && !gs->curB) | |||
| dest.details->manaLimit = -1; //we do not want to leak max mana info outside battle so set to meaningless value | |||
There was a problem hiding this comment.
This is of course not how something like that have to be implemented.
Instead you need extend InfoAboutHero's "detailed" bool and probably replace it with enum like:
EInfoLevel: BASIC, DETAILED, INBATTLE
This would let us extend info level if sometimes in future we'll have more things depend on it.
|
Changed as requested, though now there might be some code related to getting hero info that does not have to be called during battles. Disguise spell check is an example. |
Right click on hero during battle works like in original H3 now, though cursor doesn't change properly when hovering mouse over hero sprite.