Some repair for WoG commanders #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArseniyShestakov
requested changes
Oct 2, 2016
There was a problem hiding this comment.
You cannot do changes like that in classes that have serialize method and used for game save. There is way to add save compatability, but I'll instead suggest to do that ui8 -> bool change at all. Most likely it's not worth it.
If you think it's going to be good idea to do in future then better leave some comment in code about changing this after save compatability breakage. But really we don't want to break saves as long as possible.
ArseniyShestakov
approved these changes
Oct 2, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now dead commanders should not appear as units in battle. Partial fix for http://bugs.vcmi.eu/view.php?id=2430 together with 723734f