Restart button hacky fix #277
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There actually used to be a delay like 300ms. I think I removed it and wanted to debug this shit because adding delays on exit is a very dirty hack. I didn't have time to fully trace it but the real problem is surely with thread dependency hell and races. I highly encourage you to properly debug the problem instead of hacking delays. |
|
I managed to get proper solution that just works, using one boost::mutex. Before pulling it I will try to learn if something else than mutex can be better / more intuitive for code readers in this case as boost offers many interesting stuff for concurrent programming. |
|
Proper fix: #288 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some machines restart scenario button closes VCMI. This happens probably because server is not fully closed when code assumes it is (game not completely ended when starting it again). Added 1 second delay on restart, which should cause the button to work correctly most of the time.