tests/discover(add[config-scope]): parametrize classify helper

Author: tony

tests/cli/test_discover.py

@@ -2,14 +2,15 @@
 
 from __future__ import annotations
 
+import pathlib
 import re
 import subprocess
 import typing as t
 
 import pytest
 
 from vcspull._internal.private_path import PrivatePath
-from vcspull.cli.discover import discover_repos
+from vcspull.cli.discover import ConfigScope, _classify_config_scope, discover_repos
 
 if t.TYPE_CHECKING:
     import pathlib
@@ -202,6 +203,55 @@ class DiscoverFixture(t.NamedTuple):
 ]
 
 
+class ConfigScopeFixture(t.NamedTuple):
+    """Fixture describing config scope classification scenarios."""
+
+    test_id: str
+    config_template: str
+    cwd_template: str
+    env: dict[str, str]
+    expected_scope: ConfigScope
+
+
+CONFIG_SCOPE_FIXTURES: list[ConfigScopeFixture] = [
+    ConfigScopeFixture(
+        test_id="scope-user-home-default",
+        config_template="{home}/.vcspull.yaml",
+        cwd_template="{home}",
+        env={},
+        expected_scope="user",
+    ),
+    ConfigScopeFixture(
+        test_id="scope-user-xdg-home",
+        config_template="{xdg_home}/vcspull/personal.yaml",
+        cwd_template="{home}",
+        env={"XDG_CONFIG_HOME": "{xdg_home}"},
+        expected_scope="user",
+    ),
+    ConfigScopeFixture(
+        test_id="scope-system-xdg-dirs",
+        config_template="{xdg_system}/vcspull/system.yaml",
+        cwd_template="{home}",
+        env={"XDG_CONFIG_DIRS": "{xdg_system}"},
+        expected_scope="system",
+    ),
+    ConfigScopeFixture(
+        test_id="scope-project-relative",
+        config_template="{project}/.vcspull.yaml",
+        cwd_template="{project}",
+        env={},
+        expected_scope="project",
+    ),
+    ConfigScopeFixture(
+        test_id="scope-external-file",
+        config_template="{external}/configs/custom.yaml",
+        cwd_template="{project}",
+        env={},
+        expected_scope="external",
+    ),
+]
+
+
 class DiscoverLoadEdgeFixture(t.NamedTuple):
     """Fixture describing discover configuration loading edge cases."""
 
@@ -401,6 +451,67 @@ def test_discover_repos(
         )
 
 
+@pytest.mark.parametrize(
+    list(ConfigScopeFixture._fields),
+    CONFIG_SCOPE_FIXTURES,
+    ids=[fixture.test_id for fixture in CONFIG_SCOPE_FIXTURES],
+)
+def test_classify_config_scope(
+    test_id: str,
+    config_template: str,
+    cwd_template: str,
+    env: dict[str, str],
+    expected_scope: ConfigScope,
+    tmp_path: pathlib.Path,
+    monkeypatch: MonkeyPatch,
+) -> None:
+    """Ensure _classify_config_scope handles user/system/project/external paths."""
+    base_home = tmp_path / "home"
+    base_home.mkdir()
+    project = tmp_path / "project"
+    project.mkdir()
+    xdg_home = tmp_path / "xdg-home"
+    (xdg_home / "vcspull").mkdir(parents=True)
+    xdg_system = tmp_path / "xdg-system"
+    (xdg_system / "vcspull").mkdir(parents=True)
+    external = tmp_path / "external"
+    (external / "configs").mkdir(parents=True)
+
+    replacements = {
+        "home": base_home,
+        "project": project,
+        "xdg_home": xdg_home,
+        "xdg_system": xdg_system,
+        "external": external,
+    }
+
+    def _expand(template: str) -> pathlib.Path:
+        expanded = template
+        for key, path in replacements.items():
+            expanded = expanded.replace(f"{{{key}}}", str(path))
+        return pathlib.Path(expanded)
+
+    config_path = _expand(config_template)
+    config_path.parent.mkdir(parents=True, exist_ok=True)
+    config_path.touch()
+
+    cwd_path = _expand(cwd_template)
+    cwd_path.mkdir(parents=True, exist_ok=True)
+
+    monkeypatch.chdir(cwd_path)
+    monkeypatch.setenv("HOME", str(base_home))
+    for var in ["XDG_CONFIG_HOME", "XDG_CONFIG_DIRS"]:
+        monkeypatch.delenv(var, raising=False)
+    for key, value in env.items():
+        expanded_value = value
+        for name, path in replacements.items():
+            expanded_value = expanded_value.replace(f"{{{name}}}", str(path))
+        monkeypatch.setenv(key, expanded_value)
+
+    scope = _classify_config_scope(config_path, cwd=cwd_path, home=base_home)
+    assert scope == expected_scope
+
+
 @pytest.mark.parametrize(
     list(DiscoverLoadEdgeFixture._fields),
     DISCOVER_LOAD_EDGE_FIXTURES,
@@ -703,7 +814,9 @@ def test_discover_user_config_prefers_absolute_workspace_label(
     monkeypatch: MonkeyPatch,
     caplog: t.Any,
 ) -> None:
+    """User-level configs default to tilde-prefixed workspace labels."""
     import logging
+
     import yaml
 
     caplog.set_level(logging.INFO)
@@ -759,6 +872,7 @@ def test_discover_project_config_retains_relative_workspace_label(
     tmp_path: pathlib.Path,
     monkeypatch: MonkeyPatch,
 ) -> None:
+    """Project-level configs keep relative './' workspace sections."""
     import yaml
 
     home = tmp_path / "home"