Commit 0aec8fb
committed
Bugfix: MCP
`openCursorItem` in `FilePane.svelte` only read from `briefList` / `fullList`, so on the Network volume — where the cursor lives in `NetworkBrowser` (host list) or `ShareBrowser` (share list) — it always threw "No entry under cursor". Regression from the May 2026 MCP ack-contract refactor (e12285d), which replaced the keyboard-event dispatch with a direct `handleNavigate(entry)` call that bypassed the network-view branch in `handleKeyDown`.
- `NetworkBrowser`, `ShareBrowser`: new `openCursorItem()` method runs the same action Enter triggers (open host / open share / "Connect to server…").
- `NetworkMountView`: forwards to the active child (`shareBrowserRef` or `networkBrowserRef`).
- `FilePane.openCursorItem`: routes to `networkMountViewRef.openCursorItem()` when `isNetworkView`, falls through to the file-list path otherwise.
This unblocks the 3 SMB E2E tests on Linux that were red since the refactor (`smb.spec.ts:220`, `:240`, `:480`). Verified on Linux Docker (157/157) and macOS (145/145).open_under_cursor works on the Network view again1 parent e21ca6d commit 0aec8fb
5 files changed
Lines changed: 36 additions & 0 deletions
File tree
- apps/desktop/src/lib/file-explorer
- network
- pane
Lines changed: 10 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
205 | 205 | | |
206 | 206 | | |
207 | 207 | | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
208 | 218 | | |
209 | 219 | | |
210 | 220 | | |
| |||
Lines changed: 8 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
317 | 317 | | |
318 | 318 | | |
319 | 319 | | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
320 | 328 | | |
321 | 329 | | |
322 | 330 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1646 | 1646 | | |
1647 | 1647 | | |
1648 | 1648 | | |
| 1649 | + | |
| 1650 | + | |
| 1651 | + | |
| 1652 | + | |
| 1653 | + | |
| 1654 | + | |
1649 | 1655 | | |
1650 | 1656 | | |
1651 | 1657 | | |
| |||
Lines changed: 10 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
184 | 184 | | |
185 | 185 | | |
186 | 186 | | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
187 | 197 | | |
188 | 198 | | |
189 | 199 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
100 | 100 | | |
101 | 101 | | |
102 | 102 | | |
| 103 | + | |
103 | 104 | | |
104 | 105 | | |
105 | 106 | | |
| |||
112 | 113 | | |
113 | 114 | | |
114 | 115 | | |
| 116 | + | |
115 | 117 | | |
116 | 118 | | |
117 | 119 | | |
0 commit comments