Favorites: ship 'Add to favorites' with no default shortcut

Adding a favorite is infrequent, so it doesn't earn a global key by default. It stays in the command palette and is assignable in Settings > Keyboard shortcuts (grouped under Main window). The native Go-menu item carries no accelerator until the user binds one, at which point the accelerator-sync pass fills it in. Frees up `\u2318D`, which dev builds still use for the (non-configurable) Debug window.

Author: vdavid

apps/desktop/src-tauri/src/menu/linux.rs

@@ -273,7 +273,9 @@ pub(crate) fn build_menu_linux<R: Runtime>(
         true,
         Some("Cmd+J"),
     )?;
-    let favorites_add_item = MenuItem::with_id(app, FAVORITES_ADD_ID, "&Add to favorites", true, Some("Cmd+Shift+D"))?;
+    // No default accelerator: `favorites.add` ships without a default shortcut (synced from any
+    // user-assigned shortcut later).
+    let favorites_add_item = MenuItem::with_id(app, FAVORITES_ADD_ID, "&Add to favorites", true, None::<&str>)?;
 
     let go_menu = Submenu::with_items(
         app,

apps/desktop/src-tauri/src/menu/macos.rs

@@ -296,7 +296,9 @@ pub(crate) fn build_menu_macos<R: Runtime>(
     let go_to_path_item = MenuItem::with_id(app, GO_TO_PATH_ID, "Go to path\u{2026}", true, Some("Cmd+G"))?;
     let go_latest_download_item =
         MenuItem::with_id(app, GO_LATEST_DOWNLOAD_ID, "Go to latest download", true, Some("Cmd+J"))?;
-    let favorites_add_item = MenuItem::with_id(app, FAVORITES_ADD_ID, "Add to favorites", true, Some("Cmd+Shift+D"))?;
+    // No default accelerator: `favorites.add` ships without a default shortcut. The
+    // accelerator-sync pass picks up whatever the user later binds in Settings > Keyboard shortcuts.
+    let favorites_add_item = MenuItem::with_id(app, FAVORITES_ADD_ID, "Add to favorites", true, None::<&str>)?;
 
     let go_menu = Submenu::with_items(
         app,

apps/desktop/src-tauri/src/menu/mod.rs

@@ -153,9 +153,10 @@ pub const GO_TO_PATH_ID: &str = "go_to_path";
 /// "Go to latest download" (⌘J): jumps the focused pane to the most recent download.
 pub const GO_LATEST_DOWNLOAD_ID: &str = "go_latest_download";
 
-/// "Add to favorites" (⌘⇧D), menu bar + palette: maps to the `favorites.add` command, which favorites
-/// the focused pane's current folder. ⌘⇧D, not ⌘D, because dev builds bind ⌘D to "Open Debug window"
-/// (non-configurable) and the two would clash.
+/// "Add to favorites", menu bar + palette: maps to the `favorites.add` command, which favorites the
+/// focused pane's current folder. Ships with NO default shortcut (adding a favorite is infrequent);
+/// the menu item's accelerator stays empty until the user binds one in Settings > Keyboard shortcuts,
+/// at which point the accelerator-sync pass fills it in.
 pub const FAVORITES_ADD_ID: &str = "favorites_add";
 
 /// "Add to favorites", folder-row + parent-row CONTEXT menus: favorites `MenuState.context.path`

apps/desktop/src/lib/commands/command-registry.ts

@@ -156,7 +156,9 @@ export const commands: Command[] = [
     name: 'Add to favorites',
     scope: 'Main window',
     showInPalette: true,
-    shortcuts: ['⌘⇧D'],
+    // No default shortcut: adding a favorite is infrequent, so it doesn't earn a global key by
+    // default. Stays in the command palette and is assignable in Settings > Keyboard shortcuts.
+    shortcuts: [],
     description: "Add the focused pane's current folder to the switcher's Favorites.",
     keywords: ['bookmark', 'favorite', 'pin', 'shortcut'],
   },