Bugfix: Accept null for optional crash report fields

Old crash files read by a new app version deserialize `build_mode` and `short_id` as `Option::None`, and the Rust client serializes those as JSON `null` (not omitted — specta's unified mode rejects `skip_serializing_if`). The server validator was treating `null` as invalid and 400-ing the upload, losing exactly the upgrade-window reports we want to keep. Treat `null` the same as `undefined` ("field absent"), and add a regression test.

Author: vdavid

apps/api-server/src/crash-report.test.ts

@@ -100,6 +100,23 @@ describe('POST /crash-report', () => {
     expect(bindArgs[8]).toBe('CRASH-A2345')
   })
 
+  it('accepts explicit nulls for buildMode and shortId (upgrade-window compat)', async () => {
+    // Rust clients serialize `Option::None` as `null` because specta's unified mode
+    // rejects `skip_serializing_if`. Old crash files read by a new client surface as
+    // `None` and would hit this path. Reject would lose the report.
+    const { db, bindMock } = createMockD1()
+    const bindings = createBindings({ TELEMETRY_DB: db })
+
+    const report = { ...validCrashReport, buildMode: null, shortId: null }
+
+    const res = await postCrashReport(report, bindings)
+    expect(res.status).toBe(204)
+
+    const bindArgs = bindMock.mock.calls[0]
+    expect(bindArgs[7]).toBeNull()
+    expect(bindArgs[8]).toBeNull()
+  })
+
   it('returns 400 for invalid buildMode', async () => {
     const bindings = createBindings()
     const report = { ...validCrashReport, buildMode: 'staging' }

apps/api-server/src/telemetry.ts

@@ -48,12 +48,20 @@ function validateCrashReportShape(report: Record<string, unknown>): string | nul
       return `Missing required field: ${field}`
     }
   }
+  // `null` and `undefined` both mean "field absent" — old clients omit the keys,
+  // newer Rust clients serialize `Option::None` as `null` (specta's unified mode
+  // rejects `skip_serializing_if`). Treat them the same so an upgrade-window send
+  // of a pre-fix-* crash file with `None` defaults isn't rejected.
   const buildMode = report.buildMode
-  if (buildMode !== undefined && buildMode !== 'release' && buildMode !== 'debug') {
+  if (buildMode !== undefined && buildMode !== null && buildMode !== 'release' && buildMode !== 'debug') {
     return 'Invalid buildMode'
   }
   const shortId = report.shortId
-  if (shortId !== undefined && (typeof shortId !== 'string' || !crashShortIdPattern.test(shortId))) {
+  if (
+    shortId !== undefined &&
+    shortId !== null &&
+    (typeof shortId !== 'string' || !crashShortIdPattern.test(shortId))
+  ) {
     return 'Invalid shortId'
   }
   return null