Commit 41c1860
committed
Bugfix: Network pane stuck on old host after mount success
- `NetworkMountView.handleShareSelect` cleared its local `currentNetworkHost`
after a successful mount but didn't propagate the null via
`onNetworkHostChange`. The parent `FilePane` kept the stale host in its
own `$state`, so the next time the user switched back to Network (for
example, in a subsequent test), `NetworkMountView` was re-mounted with
`initialNetworkHost = <old host>` and rendered `ShareBrowser` for the old
host instead of the host list. In E2E, `move_cursor("SMB Test (Unicode)")`
then had no effect (ShareBrowser has no such share) and
`open_under_cursor` opened the wrong entry. Add `onNetworkHostChange(null)`
so the parent stays in sync.
- `ShareBrowser.loadShares` also now retries for cached non-auth errors
(`host_unreachable`, `timeout`, ...) instead of rendering the cached
error directly. User-initiated host open is an implicit "try again" —
the initial background prefetch may have run before the host was ready.
- Fixes `smb.spec.ts:436` "unicode shares render correctly" when run in
the full suite.1 parent c26f7e8 commit 41c1860
2 files changed
Lines changed: 11 additions & 5 deletions
Lines changed: 6 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
170 | 170 | | |
171 | 171 | | |
172 | 172 | | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
173 | 176 | | |
174 | | - | |
175 | | - | |
176 | | - | |
177 | | - | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
178 | 180 | | |
179 | 181 | | |
180 | 182 | | |
| |||
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
121 | 121 | | |
122 | 122 | | |
123 | 123 | | |
124 | | - | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
125 | 128 | | |
126 | 129 | | |
| 130 | + | |
127 | 131 | | |
128 | 132 | | |
129 | 133 | | |
| |||
0 commit comments