Skip to content

Commit 71dbe0b

Browse files
committed
Design: Improve text readability in many places
- Change light to dark text over theme-colored backgrounds - Nit: Fix a tiny margin in one place
1 parent d01e049 commit 71dbe0b

8 files changed

Lines changed: 26 additions & 12 deletions

File tree

apps/desktop/src/app.css

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,24 @@
2727
--color-text-secondary: #666666;
2828
--color-text-tertiary: #888888;
2929

30+
/* === macOS system accent colors (for reference / testing) ===
31+
* These are the fixed colors returned by NSColor.controlAccentColor().
32+
* "Multicolor" (the default macOS option) returns Blue. */
33+
--color-apple-blue: #087aff;
34+
--color-apple-purple: #a54fa7;
35+
--color-apple-pink: #f74f9f;
36+
--color-apple-red: #ff5157;
37+
--color-apple-orange: #f6821b;
38+
--color-apple-yellow: #ffc601;
39+
--color-apple-green: #61bb46;
40+
--color-apple-graphite: #8b8c8c;
41+
3042
/* === Interactive States ===
3143
* These accent colors are CSS fallbacks only. At runtime, the Rust backend
3244
* reads the macOS system accent color and overrides --color-accent via
3345
* accent-color.ts → initAccentColor(). See src-tauri/src/accent_color.rs. */
3446
--color-accent: #d4a006;
47+
--color-accent-fg: #1a1a1a; /* Text on accent backgrounds — dark in both themes for a11y */
3548
--color-accent-hover: color-mix(in oklch, var(--color-accent), white 15%);
3649
--color-accent-subtle: color-mix(in oklch, var(--color-accent), transparent 85%);
3750
--color-cmdr-gold: #d4a006;

apps/desktop/src/lib/file-operations/transfer/TransferDialog.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -651,7 +651,7 @@
651651
.toggle-option.active {
652652
background: var(--color-accent);
653653
border-color: var(--color-accent);
654-
color: white;
654+
color: var(--color-accent-fg);
655655
}
656656
657657
.toggle-option:not(.active):hover {

apps/desktop/src/lib/settings/components/SettingRow.svelte

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,8 +130,9 @@
130130
}
131131
132132
.restart-badge {
133-
background: var(--color-warning);
134-
color: white;
133+
background: var(--color-accent);
134+
color: var(--color-accent-fg);
135+
margin-left: var(--spacing-xs);
135136
}
136137
137138
.setting-control {

apps/desktop/src/lib/settings/components/SettingSelect.svelte

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -323,12 +323,12 @@
323323
/* Highlighted item (keyboard navigation) - same as checked for immediate feedback */
324324
:global(.select-item[data-highlighted]) {
325325
background: var(--color-accent);
326-
color: white;
326+
color: var(--color-accent-fg);
327327
}
328328
329329
:global(.select-item[data-state='checked']) {
330330
background: var(--color-accent);
331-
color: white;
331+
color: var(--color-accent-fg);
332332
}
333333
334334
:global(.select-item[data-state='checked']:hover),
@@ -353,7 +353,7 @@
353353
:global(.select-item[data-state='checked'] .item-indicator),
354354
:global(.select-item[data-highlighted] .item-indicator) {
355355
visibility: visible;
356-
color: white;
356+
color: var(--color-accent-fg);
357357
}
358358
359359
/* When Custom... is highlighted, hide the checked state from other items */

apps/desktop/src/lib/settings/components/SettingToggleGroup.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@
7171
7272
:global(.toggle-item[data-state='on']) {
7373
background: var(--color-accent);
74-
color: white;
74+
color: var(--color-accent-fg);
7575
}
7676
7777
:global(.toggle-item[data-state='on']:hover) {

apps/desktop/src/lib/settings/components/SettingsSidebar.svelte

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -306,7 +306,7 @@
306306
307307
.section-item.selected {
308308
background: var(--color-accent);
309-
color: white;
309+
color: var(--color-accent-fg);
310310
}
311311
312312
.section-item.selected:hover {
@@ -319,6 +319,6 @@
319319
}
320320
321321
.section-item.subsection.selected {
322-
color: white;
322+
color: var(--color-accent-fg);
323323
}
324324
</style>

apps/desktop/src/lib/settings/sections/KeyboardShortcutsSection.svelte

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -556,7 +556,7 @@
556556
557557
.filter-chip.active {
558558
background: var(--color-accent);
559-
color: white;
559+
color: var(--color-accent-fg);
560560
border-color: var(--color-accent);
561561
}
562562
@@ -681,7 +681,7 @@
681681
682682
.shortcut-pill.editing {
683683
background: var(--color-accent);
684-
color: white;
684+
color: var(--color-accent-fg);
685685
border-color: var(--color-accent);
686686
}
687687

apps/desktop/src/lib/ui/Button.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@
7171
/* === Variant: primary === */
7272
.btn-primary {
7373
background: var(--color-accent);
74-
color: white;
74+
color: var(--color-accent-fg);
7575
border: none;
7676
}
7777

0 commit comments

Comments
 (0)