Tooling: Replace prettier with oxfmt

vdavid · vdavid · commit 995f8c8e5a65 · 2026-03-31T09:03:10.000+02:00
It's a whole lot, like 10-20x, faster!
diff --git a/.oxfmtrc.json b/.oxfmtrc.json
@@ -0,0 +1,29 @@
+{
+    "$schema": "./node_modules/oxfmt/configuration_schema.json",
+    "tabWidth": 4,
+    "useTabs": false,
+    "semi": false,
+    "singleQuote": true,
+    "quoteProps": "as-needed",
+    "trailingComma": "all",
+    "bracketSpacing": true,
+    "bracketSameLine": false,
+    "arrowParens": "always",
+    "endOfLine": "lf",
+    "printWidth": 120,
+    "proseWrap": "always",
+    "sortPackageJson": false,
+    "ignorePatterns": [
+        "node_modules/",
+        "**/dist/",
+        "**/build/",
+        "**/.svelte-kit/",
+        "**/.astro/",
+        "**/src-tauri/",
+        "pnpm-lock.yaml",
+        "**/playwright-report/",
+        "**/test-results/",
+        "**/coverage/",
+        "apps/website/src/pages/pricing.astro"
+    ]
+}
diff --git a/apps/api-server/.oxfmtrc.json b/apps/api-server/.oxfmtrc.json
@@ -0,0 +1,17 @@
+{
+    "$schema": "./node_modules/oxfmt/configuration_schema.json",
+    "tabWidth": 4,
+    "useTabs": false,
+    "semi": false,
+    "singleQuote": true,
+    "quoteProps": "as-needed",
+    "trailingComma": "all",
+    "bracketSpacing": true,
+    "bracketSameLine": false,
+    "arrowParens": "always",
+    "endOfLine": "lf",
+    "printWidth": 120,
+    "proseWrap": "always",
+    "sortPackageJson": false,
+    "ignorePatterns": []
+}
diff --git a/apps/api-server/package.json b/apps/api-server/package.json
@@ -30,6 +30,7 @@
         "eslint-config-prettier": "^10.1.8",
         "eslint-plugin-prettier": "^5.5.5",
         "globals": "^17.4.0",
+        "oxfmt": "^0.42.0",
         "prettier": "^3.8.1",
         "typescript": "^5.9.3",
         "typescript-eslint": "^8.57.1",
diff --git a/apps/desktop/.oxfmtrc.json b/apps/desktop/.oxfmtrc.json
@@ -0,0 +1,26 @@
+{
+    "$schema": "./node_modules/oxfmt/configuration_schema.json",
+    "tabWidth": 4,
+    "useTabs": false,
+    "semi": false,
+    "singleQuote": true,
+    "quoteProps": "as-needed",
+    "trailingComma": "all",
+    "bracketSpacing": true,
+    "bracketSameLine": false,
+    "arrowParens": "always",
+    "endOfLine": "lf",
+    "printWidth": 120,
+    "proseWrap": "always",
+    "sortPackageJson": false,
+    "ignorePatterns": [
+        ".svelte-kit/",
+        "src-tauri/",
+        "build/",
+        "dist/",
+        "pnpm-lock.yaml",
+        "playwright-report/",
+        "test-results/",
+        "coverage/"
+    ]
+}
diff --git a/apps/desktop/package.json b/apps/desktop/package.json
@@ -76,6 +76,7 @@
         "globals": "^17.4.0",
         "jsdom": "^29.0.1",
         "knip": "^6.0.3",
+        "oxfmt": "^0.42.0",
         "oxlint": "^1.56.0",
         "postcss-html": "^1.8.1",
         "prettier": "^3.8.1",
diff --git a/apps/desktop/src/lib/file-explorer/views/FullList.svelte b/apps/desktop/src/lib/file-explorer/views/FullList.svelte
@@ -379,7 +379,12 @@
 
 <div class="full-list-container" class:is-focused={isFocused} class:is-compact={isCompact}>
     <!-- Header row with sortable columns (outside scroll container for correct height calculation) -->
-    <div class="header-row" role="toolbar" aria-label="Sort columns" style="grid-template-columns: 16px 1fr 60px 115px {dateColumnWidth}px;">
+    <div
+        class="header-row"
+        role="toolbar"
+        aria-label="Sort columns"
+        style="grid-template-columns: 16px 1fr 60px 115px {dateColumnWidth}px;"
+    >
         <span class="header-icon"></span>
         <SortableHeader
             column="name"
diff --git a/apps/desktop/src/lib/settings/components/SettingNumberInput.svelte b/apps/desktop/src/lib/settings/components/SettingNumberInput.svelte
@@ -43,9 +43,13 @@
 <div class="number-input-wrapper">
     <NumberInput.Root value={String(value)} onValueChange={handleChange} {min} {max} {step} {disabled}>
         <NumberInput.Control class="number-control">
-            <NumberInput.DecrementTrigger class="number-btn" aria-label="Decrease {label}">−</NumberInput.DecrementTrigger>
+            <NumberInput.DecrementTrigger class="number-btn" aria-label="Decrease {label}"
+                >−</NumberInput.DecrementTrigger
+            >
             <NumberInput.Input class="number-input" aria-label={label} />
-            <NumberInput.IncrementTrigger class="number-btn" aria-label="Increase {label}">+</NumberInput.IncrementTrigger>
+            <NumberInput.IncrementTrigger class="number-btn" aria-label="Increase {label}"
+                >+</NumberInput.IncrementTrigger
+            >
         </NumberInput.Control>
     </NumberInput.Root>
 
diff --git a/apps/desktop/src/lib/settings/components/SettingSlider.svelte b/apps/desktop/src/lib/settings/components/SettingSlider.svelte
@@ -79,7 +79,16 @@
 </script>
 
 <div class="slider-wrapper">
-    <Slider.Root value={[value]} onValueChange={handleSliderChange} {min} {max} {step} {disabled} class="slider-root" aria-label={label}>
+    <Slider.Root
+        value={[value]}
+        onValueChange={handleSliderChange}
+        {min}
+        {max}
+        {step}
+        {disabled}
+        class="slider-root"
+        aria-label={label}
+    >
         <Slider.Control class="slider-control">
             <Slider.Track class="slider-track">
                 <Slider.Range class="slider-range" />
diff --git a/apps/desktop/src/lib/settings/components/SettingSwitch.svelte b/apps/desktop/src/lib/settings/components/SettingSwitch.svelte
@@ -1,6 +1,13 @@
 <script lang="ts">
     import { Switch } from '@ark-ui/svelte/switch'
-    import { getSetting, setSetting, getSettingDefinition, onSpecificSettingChange, type SettingId, type SettingsValues } from '$lib/settings'
+    import {
+        getSetting,
+        setSetting,
+        getSettingDefinition,
+        onSpecificSettingChange,
+        type SettingId,
+        type SettingsValues,
+    } from '$lib/settings'
     import { onMount } from 'svelte'
 
     interface Props {
diff --git a/apps/desktop/src/lib/settings/sections/AdvancedSection.svelte b/apps/desktop/src/lib/settings/sections/AdvancedSection.svelte
@@ -148,9 +148,13 @@
                             step={setting.constraints?.step ?? 1}
                         >
                             <NumberInput.Control class="number-control">
-                                <NumberInput.DecrementTrigger class="number-btn" aria-label="Decrease {setting.label}">−</NumberInput.DecrementTrigger>
+                                <NumberInput.DecrementTrigger class="number-btn" aria-label="Decrease {setting.label}"
+                                    >−</NumberInput.DecrementTrigger
+                                >
                                 <NumberInput.Input class="number-input" aria-label={setting.label} />
-                                <NumberInput.IncrementTrigger class="number-btn" aria-label="Increase {setting.label}">+</NumberInput.IncrementTrigger>
+                                <NumberInput.IncrementTrigger class="number-btn" aria-label="Increase {setting.label}"
+                                    >+</NumberInput.IncrementTrigger
+                                >
                             </NumberInput.Control>
                         </NumberInput.Root>
                         {#if setting.type === 'duration' && setting.constraints?.unit}
diff --git a/apps/desktop/test/e2e-playwright/accessibility.spec.ts b/apps/desktop/test/e2e-playwright/accessibility.spec.ts
@@ -74,9 +74,7 @@ async function runAxeAudit(
 }> {
     await injectAxe(tauriPage)
 
-    const axeCall = scope
-        ? `axe.run(document.querySelector(${JSON.stringify(scope)}))`
-        : 'axe.run()'
+    const axeCall = scope ? `axe.run(document.querySelector(${JSON.stringify(scope)}))` : 'axe.run()'
     const results = await tauriPage.evaluate<AxeResults>(axeCall)
 
     const critical = results.violations.filter((v) => v.impact === 'critical')
diff --git a/apps/website/.oxfmtrc.json b/apps/website/.oxfmtrc.json
@@ -0,0 +1,17 @@
+{
+    "$schema": "./node_modules/oxfmt/configuration_schema.json",
+    "tabWidth": 4,
+    "useTabs": false,
+    "semi": false,
+    "singleQuote": true,
+    "quoteProps": "as-needed",
+    "trailingComma": "all",
+    "bracketSpacing": true,
+    "bracketSameLine": false,
+    "arrowParens": "always",
+    "endOfLine": "lf",
+    "printWidth": 120,
+    "proseWrap": "always",
+    "sortPackageJson": false,
+    "ignorePatterns": ["src/pages/pricing.astro", "playwright-report/", "test-results/"]
+}
diff --git a/apps/website/e2e/accessibility.spec.ts b/apps/website/e2e/accessibility.spec.ts
@@ -48,8 +48,12 @@ for (const theme of ['light', 'dark'] as const) {
                     console.log(
                         `[axe/${v.impact}] [${name} ${theme}] ${v.id}: ${v.description}\n` +
                             `  Help: ${v.helpUrl}\n` +
-                            v.nodes.map((n: { html: string; failureSummary: string }) =>
-                                `  - ${n.html}\n    ${n.failureSummary}`).join('\n'),
+                            v.nodes
+                                .map(
+                                    (n: { html: string; failureSummary: string }) =>
+                                        `  - ${n.html}\n    ${n.failureSummary}`,
+                                )
+                                .join('\n'),
                     )
                 }
 
@@ -66,14 +70,8 @@ for (const theme of ['light', 'dark'] as const) {
                     }
                 }
 
-                expect(
-                    critical,
-                    `${name} (${theme}): ${critical.length} critical violation(s)`,
-                ).toHaveLength(0)
-                expect(
-                    serious,
-                    `${name} (${theme}): ${serious.length} serious violation(s)`,
-                ).toHaveLength(0)
+                expect(critical, `${name} (${theme}): ${critical.length} critical violation(s)`).toHaveLength(0)
+                expect(serious, `${name} (${theme}): ${serious.length} serious violation(s)`).toHaveLength(0)
             })
         }
     })
diff --git a/apps/website/package.json b/apps/website/package.json
@@ -42,6 +42,7 @@
         "eslint-plugin-prettier": "^5.5.5",
         "globals": "^17.4.0",
         "html-validate": "^10.11.1",
+        "oxfmt": "^0.42.0",
         "prettier": "^3.8.1",
         "prettier-plugin-astro": "^0.14.1",
         "serve": "14.2.6",
diff --git a/package.json b/package.json
@@ -28,5 +28,8 @@
             "sharp",
             "workerd"
         ]
+    },
+    "devDependencies": {
+        "oxfmt": "^0.42.0"
     }
 }
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/scripts/check/CLAUDE.md b/scripts/check/CLAUDE.md
@@ -255,9 +255,10 @@ these checks.
 checks (no Docker daemon on freestyle VMs). With `--prefer-freestyle` these run locally in parallel;
 with `--only-freestyle` they're skipped.
 
-**VM lifecycle:** The VM is created once (takes ~5.5 min for toolchain setup), then persists and
-auto-suspends after 5 min idle. Subsequent runs resume it in <1s. VM ID is stored in `.freestyle-vm-id`
-(gitignored). On wake, a health check verifies the toolchain; if it fails, the VM is replaced.
+**VM lifecycle:** The VM is created once (toolchain setup), then uses `persistent` storage so it
+survives freestyle's resource management. It auto-suspends after 5 min idle but resumes in <1s. VM ID
+is stored in `.freestyle-vm-id` (gitignored). On wake, a health check verifies the toolchain; if it
+fails, the VM is replaced. Setup parallelizes pnpm + Playwright install and uses a shallow clone.
 
 **Key files:** `freestyle.go` (all freestyle logic including `preferFreestyleRun`), `main.go`
 (`handleFreestyleFlags` dispatches to the right mode).
diff --git a/scripts/check/checks/api-server-oxfmt.go b/scripts/check/checks/api-server-oxfmt.go
@@ -0,0 +1,9 @@
+package checks
+
+import "path/filepath"
+
+// RunApiServerOxfmt runs oxfmt on the API server.
+func RunApiServerOxfmt(ctx *CheckContext) (CheckResult, error) {
+	dir := filepath.Join(ctx.RootDir, "apps", "api-server")
+	return runOxfmtCheck(ctx, dir, []string{"*.ts", "*.js"})
+}
diff --git a/scripts/check/checks/api-server-prettier.go b/scripts/check/checks/api-server-prettier.go
diff --git a/scripts/check/checks/common.go b/scripts/check/checks/common.go
@@ -339,6 +339,67 @@ func runPrettierCheck(ctx *CheckContext, dir string, extensions []string) (Check
 	return result, nil
 }
 
+// runOxfmtCheck runs oxfmt formatting check/fix for a given directory.
+// extensions are the file extensions to count (like []string{"*.ts", "*.js"}).
+func runOxfmtCheck(ctx *CheckContext, dir string, extensions []string) (CheckResult, error) {
+	// Count files that oxfmt would check
+	findArgs := buildFindArgs("src", extensions)
+	findCmd := exec.Command("find", findArgs...)
+	findCmd.Dir = dir
+	findOutput, _ := RunCommand(findCmd, true)
+	fileCount := 0
+	if strings.TrimSpace(findOutput) != "" {
+		fileCount = len(strings.Split(strings.TrimSpace(findOutput), "\n"))
+	}
+
+	if ctx.CI {
+		checkCmd := exec.Command("pnpm", "exec", "oxfmt", "--check", ".")
+		checkCmd.Dir = dir
+		checkOutput, err := RunCommand(checkCmd, true)
+		if err != nil {
+			return CheckResult{}, fmt.Errorf("code is not formatted, run `pnpm exec oxfmt .` locally\n%s", indentOutput(checkOutput))
+		}
+		result := Success(fmt.Sprintf("%d %s already formatted", fileCount, Pluralize(fileCount, "file", "files")))
+		result.Total = fileCount
+		result.Issues = 0
+		result.Changes = 0
+		return result, nil
+	}
+
+	// Non-CI: check first, then format if needed
+	checkCmd := exec.Command("pnpm", "exec", "oxfmt", "--check", ".")
+	checkCmd.Dir = dir
+	checkOutput, checkErr := RunCommand(checkCmd, true)
+
+	if checkErr != nil {
+		fmtCmd := exec.Command("pnpm", "exec", "oxfmt", ".")
+		fmtCmd.Dir = dir
+		fmtOutput, err := RunCommand(fmtCmd, true)
+		if err != nil {
+			return CheckResult{}, fmt.Errorf("oxfmt formatting failed\n%s", indentOutput(fmtOutput))
+		}
+
+		var needsFormat int
+		for _, line := range strings.Split(strings.TrimSpace(checkOutput), "\n") {
+			if strings.TrimSpace(line) != "" && !strings.HasPrefix(line, "Checking") && !strings.HasPrefix(line, "Finished") && !strings.HasPrefix(line, "Format") {
+				needsFormat++
+			}
+		}
+
+		result := SuccessWithChanges(fmt.Sprintf("Formatted %d of %d %s", needsFormat, fileCount, Pluralize(fileCount, "file", "files")))
+		result.Total = fileCount
+		result.Issues = needsFormat
+		result.Changes = needsFormat
+		return result, nil
+	}
+
+	result := Success(fmt.Sprintf("%d %s already formatted", fileCount, Pluralize(fileCount, "file", "files")))
+	result.Total = fileCount
+	result.Issues = 0
+	result.Changes = 0
+	return result, nil
+}
+
 // runESLintCheck runs ESLint check/fix for a given directory.
 // extensions are the file extensions to count (like []string{"*.ts", "*.svelte", "*.js"}).
 // If requireConfig is true, skips when eslint.config.js is missing.
diff --git a/scripts/check/checks/desktop-svelte-oxfmt.go b/scripts/check/checks/desktop-svelte-oxfmt.go
diff --git a/scripts/check/checks/registry.go b/scripts/check/checks/registry.go
diff --git a/scripts/check/checks/website-oxfmt.go b/scripts/check/checks/website-oxfmt.go
