Linux polish: shortcuts, menus, error msgs, E2E

- Volume choosers now use ⌥F1/⌥F2 on both platforms (was bare F1 + no right shortcut). Removed dead handleFunctionKey() from DualPaneExplorer.
- Fix F2 rename on Linux: GTK menu accelerator was swallowing the key before it reached the webview. Removed F2 accelerator from Linux menu, letting centralized dispatch handle it.
- 'Win' → 'Super' in formatKeyCombo() for standard Linux terminology.
- Quick Look/Get Info: return no-op on Linux instead of error toast, unbind ⌘I (Ctrl+I) on Linux.
- Appearance settings: DE detection via $XDG_CURRENT_DESKTOP (GNOME, KDE, XFCE) replacing broken xdg-open call.
- GTK menu mnemonics on all labels (macOS silently strips & prefixes).
- Replaced macOS-specific error strings (Finder, System Preferences, Full Disk Access) with platform-neutral text.
- New inotify file-watching E2E test.
- Update AGENTS.md to make sure we think in platform-native messaging on the UI

Author: vdavid

AGENTS.md

@@ -107,6 +107,12 @@ There are two MCP servers available to you:
   processes as well, to avoid wasting the user's resources.
 - When shortcuts are available for a feature, always display the shortcut in a tooltip or somewhere, less prominent than
   the main UI.
+- **Platform-native, not generic.** The app should look and feel as if it was specifically made for the user's OS. Never
+  generalize user-facing text, labels, or behavior to be "cross-platform" — instead, fork by OS. On macOS, say "Finder",
+  "Trash", "System Settings". On Linux, say "file manager", "Trash" (FreeDesktop spec), and use DE-specific terminology
+  where possible. Windows (later) gets its own native terms too. This applies to error messages, menu labels, tooltips,
+  and any user-visible string. Use `isMacOS()` / `cfg(target_os)` to branch — a few extra lines of platform-specific
+  text are always better than one watered-down generic string.
 
 ## Checklist for new features
 

apps/desktop/src-tauri/src/commands/ui.rs

@@ -100,6 +100,7 @@ pub fn show_in_finder(path: String) -> Result<(), String> {
     Ok(())
 }
 
+/// Show a file in the default file manager (open parent folder via xdg-open)
 #[tauri::command]
 #[cfg(target_os = "linux")]
 pub fn show_in_finder(path: String) -> Result<(), String> {
@@ -140,10 +141,10 @@ pub fn quick_look(path: String) -> Result<(), String> {
 #[tauri::command]
 #[cfg(not(target_os = "macos"))]
 pub fn quick_look(_path: String) -> Result<(), String> {
-    Err("Quick Look is only available on macOS".to_string())
+    Ok(())
 }
 
-/// Open Get Info window in Finder (macOS only)
+/// Open the Get Info window for a file (macOS only, no-op on other platforms)
 #[tauri::command]
 #[cfg(target_os = "macos")]
 pub fn get_info(path: String) -> Result<(), String> {
@@ -167,7 +168,7 @@ pub fn get_info(path: String) -> Result<(), String> {
 #[tauri::command]
 #[cfg(not(target_os = "macos"))]
 pub fn get_info(_path: String) -> Result<(), String> {
-    Err("Get Info is only available on macOS".to_string())
+    Ok(())
 }
 
 /// Open file in the system's default text editor (macOS only)

apps/desktop/src-tauri/src/menu.rs

@@ -159,7 +159,7 @@ fn show_in_file_manager_label() -> &'static str {
 
 #[cfg(not(target_os = "macos"))]
 fn show_in_file_manager_label() -> &'static str {
-    "Show in file manager"
+    "Show in &file manager"
 }
 
 /// Builds the application menu with default macOS items plus a custom View and File submenu enhancements.
@@ -481,8 +481,8 @@ fn build_menu_linux<R: Runtime>(
     let menu = Menu::new(app)?;
 
     // --- File menu ---
-    let open_item = MenuItem::with_id(app, OPEN_ID, "Open", true, None::<&str>)?;
-    let edit_item = MenuItem::with_id(app, EDIT_ID, "Edit", true, Some("F4"))?;
+    let open_item = MenuItem::with_id(app, OPEN_ID, "&Open", true, None::<&str>)?;
+    let edit_item = MenuItem::with_id(app, EDIT_ID, "&Edit", true, Some("F4"))?;
     let show_in_fm_item = MenuItem::with_id(
         app,
         SHOW_IN_FINDER_ID,
@@ -493,18 +493,18 @@ fn build_menu_linux<R: Runtime>(
     let copy_path_item = MenuItem::with_id(
         app,
         COPY_PATH_ID,
-        "Copy path to clipboard",
+        "Copy &path to clipboard",
         true,
         Some(copy_path_accelerator()),
     )?;
-    let copy_filename_item = MenuItem::with_id(app, COPY_FILENAME_ID, "Copy filename", true, None::<&str>)?;
-    let new_tab_item = MenuItem::with_id(app, NEW_TAB_ID, "New tab", true, Some("Cmd+T"))?;
-    let pin_tab_item = MenuItem::with_id(app, PIN_TAB_MENU_ID, "Pin tab", true, None::<&str>)?;
-    let close_tab_item = MenuItem::with_id(app, CLOSE_TAB_ID, "Close tab", true, Some("Cmd+W"))?;
+    let copy_filename_item = MenuItem::with_id(app, COPY_FILENAME_ID, "Copy file&name", true, None::<&str>)?;
+    let new_tab_item = MenuItem::with_id(app, NEW_TAB_ID, "New &tab", true, Some("Cmd+T"))?;
+    let pin_tab_item = MenuItem::with_id(app, PIN_TAB_MENU_ID, "P&in tab", true, None::<&str>)?;
+    let close_tab_item = MenuItem::with_id(app, CLOSE_TAB_ID, "&Close tab", true, Some("Cmd+W"))?;
 
     let file_menu = Submenu::with_items(
         app,
-        "File",
+        "&File",
         true,
         &[
             &open_item,
@@ -521,27 +521,30 @@ fn build_menu_linux<R: Runtime>(
     menu.append(&file_menu)?;
 
     // --- Edit menu ---
-    let rename_item = MenuItem::with_id(app, RENAME_ID, "Rename", true, Some("F2"))?;
-    let settings_item = MenuItem::with_id(app, SETTINGS_ID, "Settings...", true, Some("Cmd+,"))?;
+    // No accelerator — F2 is handled by the webview's centralized shortcut dispatch.
+    // GTK menu accelerators intercept keys before they reach the webview, and the
+    // is_focused() check in on_menu_event fails on Linux, so F2 rename never fires.
+    let rename_item = MenuItem::with_id(app, RENAME_ID, "Re&name", true, None::<&str>)?;
+    let settings_item = MenuItem::with_id(app, SETTINGS_ID, "&Settings...", true, Some("Cmd+,"))?;
     let license_label = if has_existing_license {
-        "See license details..."
+        "See &license details..."
     } else {
-        "Enter license key..."
+        "Enter &license key..."
     };
     let license_item = MenuItem::with_id(app, ENTER_LICENSE_KEY_ID, license_label, true, None::<&str>)?;
 
     let edit_menu = Submenu::with_items(
         app,
-        "Edit",
+        "&Edit",
         true,
         &[
-            &PredefinedMenuItem::undo(app, None)?,
-            &PredefinedMenuItem::redo(app, None)?,
+            &PredefinedMenuItem::undo(app, Some("&Undo"))?,
+            &PredefinedMenuItem::redo(app, Some("&Redo"))?,
             &PredefinedMenuItem::separator(app)?,
-            &PredefinedMenuItem::cut(app, None)?,
-            &PredefinedMenuItem::copy(app, None)?,
-            &PredefinedMenuItem::paste(app, None)?,
-            &PredefinedMenuItem::select_all(app, None)?,
+            &PredefinedMenuItem::cut(app, Some("Cu&t"))?,
+            &PredefinedMenuItem::copy(app, Some("&Copy"))?,
+            &PredefinedMenuItem::paste(app, Some("&Paste"))?,
+            &PredefinedMenuItem::select_all(app, Some("Select &all"))?,
             &PredefinedMenuItem::separator(app)?,
             &rename_item,
             &PredefinedMenuItem::separator(app)?,
@@ -555,39 +558,39 @@ fn build_menu_linux<R: Runtime>(
     let view_mode_full_item = CheckMenuItem::with_id(
         app,
         VIEW_MODE_FULL_ID,
-        "Full view",
+        "&Full view",
         true,
         view_mode == ViewMode::Full,
         Some("Cmd+1"),
     )?;
     let view_mode_brief_item = CheckMenuItem::with_id(
         app,
         VIEW_MODE_BRIEF_ID,
-        "Brief view",
+        "&Brief view",
         true,
         view_mode == ViewMode::Brief,
         Some("Cmd+2"),
     )?;
     let show_hidden_item = CheckMenuItem::with_id(
         app,
         SHOW_HIDDEN_FILES_ID,
-        "Show hidden files",
+        "Show &hidden files",
         true,
         show_hidden_files,
         Some("Cmd+Shift+."),
     )?;
 
     // Sort by submenu
-    let sort_by_name = MenuItem::with_id(app, SORT_BY_NAME_ID, "Name", true, None::<&str>)?;
-    let sort_by_ext = MenuItem::with_id(app, SORT_BY_EXTENSION_ID, "Extension", true, None::<&str>)?;
-    let sort_by_size = MenuItem::with_id(app, SORT_BY_SIZE_ID, "Size", true, None::<&str>)?;
-    let sort_by_modified = MenuItem::with_id(app, SORT_BY_MODIFIED_ID, "Date modified", true, None::<&str>)?;
-    let sort_by_created = MenuItem::with_id(app, SORT_BY_CREATED_ID, "Date created", true, None::<&str>)?;
-    let sort_asc = MenuItem::with_id(app, SORT_ASCENDING_ID, "Ascending", true, None::<&str>)?;
-    let sort_desc = MenuItem::with_id(app, SORT_DESCENDING_ID, "Descending", true, None::<&str>)?;
+    let sort_by_name = MenuItem::with_id(app, SORT_BY_NAME_ID, "&Name", true, None::<&str>)?;
+    let sort_by_ext = MenuItem::with_id(app, SORT_BY_EXTENSION_ID, "&Extension", true, None::<&str>)?;
+    let sort_by_size = MenuItem::with_id(app, SORT_BY_SIZE_ID, "&Size", true, None::<&str>)?;
+    let sort_by_modified = MenuItem::with_id(app, SORT_BY_MODIFIED_ID, "Date &modified", true, None::<&str>)?;
+    let sort_by_created = MenuItem::with_id(app, SORT_BY_CREATED_ID, "Date &created", true, None::<&str>)?;
+    let sort_asc = MenuItem::with_id(app, SORT_ASCENDING_ID, "&Ascending", true, None::<&str>)?;
+    let sort_desc = MenuItem::with_id(app, SORT_DESCENDING_ID, "&Descending", true, None::<&str>)?;
     let sort_submenu = Submenu::with_items(
         app,
-        "Sort by",
+        "&Sort by",
         true,
         &[
             &sort_by_name,
@@ -601,14 +604,19 @@ fn build_menu_linux<R: Runtime>(
         ],
     )?;
 
-    let command_palette_item =
-        MenuItem::with_id(app, COMMAND_PALETTE_ID, "Command palette...", true, Some("Cmd+Shift+P"))?;
-    let switch_pane_item = MenuItem::with_id(app, SWITCH_PANE_ID, "Switch pane", true, Some("Tab"))?;
-    let swap_panes_item = MenuItem::with_id(app, SWAP_PANES_ID, "Swap panes", true, Some("Cmd+U"))?;
+    let command_palette_item = MenuItem::with_id(
+        app,
+        COMMAND_PALETTE_ID,
+        "&Command palette...",
+        true,
+        Some("Cmd+Shift+P"),
+    )?;
+    let switch_pane_item = MenuItem::with_id(app, SWITCH_PANE_ID, "S&witch pane", true, Some("Tab"))?;
+    let swap_panes_item = MenuItem::with_id(app, SWAP_PANES_ID, "Swa&p panes", true, Some("Cmd+U"))?;
 
     let view_submenu = Submenu::with_items(
         app,
-        "View",
+        "&View",
         true,
         &[
             &view_mode_full_item,
@@ -629,13 +637,13 @@ fn build_menu_linux<R: Runtime>(
     let view_brief_pos: usize = 1;
 
     // --- Go menu ---
-    let go_back_item = MenuItem::with_id(app, GO_BACK_ID, "Back", true, Some("Cmd+["))?;
-    let go_forward_item = MenuItem::with_id(app, GO_FORWARD_ID, "Forward", true, Some("Cmd+]"))?;
-    let go_parent_item = MenuItem::with_id(app, GO_PARENT_ID, "Parent folder", true, Some("Cmd+Up"))?;
+    let go_back_item = MenuItem::with_id(app, GO_BACK_ID, "&Back", true, Some("Cmd+["))?;
+    let go_forward_item = MenuItem::with_id(app, GO_FORWARD_ID, "&Forward", true, Some("Cmd+]"))?;
+    let go_parent_item = MenuItem::with_id(app, GO_PARENT_ID, "&Parent folder", true, Some("Cmd+Up"))?;
 
     let go_menu = Submenu::with_items(
         app,
-        "Go",
+        "&Go",
         true,
         &[
             &go_back_item,
@@ -647,8 +655,8 @@ fn build_menu_linux<R: Runtime>(
     menu.append(&go_menu)?;
 
     // --- Help menu ---
-    let about_item = MenuItem::with_id(app, ABOUT_ID, "About cmdr", true, None::<&str>)?;
-    let help_menu = Submenu::with_items(app, "Help", true, &[&about_item])?;
+    let about_item = MenuItem::with_id(app, ABOUT_ID, "&About cmdr", true, None::<&str>)?;
+    let help_menu = Submenu::with_items(app, "&Help", true, &[&about_item])?;
     menu.append(&help_menu)?;
 
     Ok(MenuItems {
@@ -747,8 +755,8 @@ pub fn build_viewer_menu<R: Runtime>(app: &AppHandle<R>) -> tauri::Result<Menu<R
     {
         let menu = Menu::new(app)?;
 
-        let word_wrap_item = CheckMenuItem::with_id(app, VIEWER_WORD_WRAP_ID, "Word wrap", true, false, None::<&str>)?;
-        let view_submenu = Submenu::with_items(app, "View", true, &[&word_wrap_item])?;
+        let word_wrap_item = CheckMenuItem::with_id(app, VIEWER_WORD_WRAP_ID, "&Word wrap", true, false, None::<&str>)?;
+        let view_submenu = Submenu::with_items(app, "&View", true, &[&word_wrap_item])?;
         menu.append(&view_submenu)?;
 
         Ok(menu)
@@ -874,14 +882,14 @@ pub fn update_view_mode_accelerator<R: Runtime>(
             menu_state.view_mode_full.lock_ignore_poison(),
             menu_state.view_mode_full_position.lock_ignore_poison(),
             VIEW_MODE_FULL_ID,
-            "Full view",
+            "&Full view",
         )
     } else {
         (
             menu_state.view_mode_brief.lock_ignore_poison(),
             menu_state.view_mode_brief_position.lock_ignore_poison(),
             VIEW_MODE_BRIEF_ID,
-            "Brief view",
+            "&Brief view",
         )
     };
 

apps/desktop/src-tauri/src/permissions_linux.rs

@@ -17,14 +17,27 @@ pub fn open_privacy_settings() -> Result<(), String> {
     // GNOME: gnome-control-center privacy
     // KDE: systemsettings (no direct privacy section URL)
     // Fallback: xdg-open is unlikely to have a privacy URI, so return an error.
-    Err("Privacy settings are not applicable on Linux".to_string())
+    Err("Privacy settings aren't needed on Linux — file access is governed by standard Unix permissions, not app sandboxing.".to_string())
 }
 
 /// Opens the system appearance settings via the desktop environment.
+/// Detects the DE from `$XDG_CURRENT_DESKTOP` and launches the appropriate settings app.
 #[tauri::command]
 pub fn open_appearance_settings() -> Result<(), String> {
-    std::process::Command::new("xdg-open")
-        .arg("gnome-control-center")
+    let desktop = std::env::var("XDG_CURRENT_DESKTOP").unwrap_or_default().to_uppercase();
+
+    let (cmd, args): (&str, &[&str]) = if desktop.contains("GNOME") {
+        ("gnome-control-center", &["appearance"])
+    } else if desktop.contains("KDE") {
+        ("systemsettings", &["kcm_lookandfeel"])
+    } else if desktop.contains("XFCE") {
+        ("xfce4-appearance-settings", &[])
+    } else {
+        return Err("Appearance settings are not available for your desktop environment.".to_string());
+    };
+
+    std::process::Command::new(cmd)
+        .args(args)
         .spawn()
         .map_err(|e| format!("Failed to open appearance settings: {e}"))?;
     Ok(())

apps/desktop/src/lib/commands/command-registry.ts

@@ -76,14 +76,14 @@ export const commands: Command[] = [
         name: 'Open left volume chooser',
         scope: 'Main window',
         showInPalette: true,
-        shortcuts: ['F1'],
+        shortcuts: ['⌥F1'],
     },
     {
         id: 'pane.rightVolumeChooser',
         name: 'Open right volume chooser',
         scope: 'Main window',
         showInPalette: true,
-        shortcuts: [],
+        shortcuts: ['⌥F2'],
     },
 
     // ============================================================================
@@ -261,7 +261,7 @@ export const commands: Command[] = [
         name: isMacOS() ? 'Get info' : 'File properties',
         scope: 'Main window/File list',
         showInPalette: isMacOS(),
-        shortcuts: ['⌘I'],
+        shortcuts: isMacOS() ? ['⌘I'] : [],
     },
     {
         id: 'file.quickLook',

apps/desktop/src/lib/file-explorer/pane/DualPaneExplorer.svelte

@@ -613,30 +613,13 @@
         return false
     }
 
-    /** Handles the F1 key (volume chooser toggle). Returns true if handled. */
-    function handleFunctionKey(e: KeyboardEvent): boolean {
-        if (e.key === 'F1') {
-            // eslint-disable-next-line @typescript-eslint/no-unsafe-call
-            getPaneRef('right')?.closeVolumeChooser()
-            // eslint-disable-next-line @typescript-eslint/no-unsafe-call
-            getPaneRef('left')?.toggleVolumeChooser()
-            return true
-        }
-        return false
-    }
-
     function handleKeyDown(e: KeyboardEvent) {
         // ESC during loading = cancel and go back
         if (e.key === 'Escape' && handleEscapeDuringLoading()) {
             e.preventDefault()
             return
         }
 
-        if (handleFunctionKey(e)) {
-            e.preventDefault()
-            return
-        }
-
         // Route to volume chooser if one is open
         if (routeToVolumeChooser(e)) {
             return

apps/desktop/src/lib/file-explorer/pane/PermissionDeniedPane.svelte

@@ -1,6 +1,7 @@
 <script lang="ts">
     import { DotLottieSvelte } from '@lottiefiles/dotlottie-svelte'
     import { openPrivacySettings } from '$lib/tauri-commands'
+    import { isMacOS } from '$lib/shortcuts/key-capture'
     import Button from '$lib/ui/Button.svelte'
 
     interface Props {
@@ -15,16 +16,20 @@
         <div class="icon"><DotLottieSvelte src="/icons/lock-closing.lottie" autoplay speed={0.5} /></div>
         <h2>No permission</h2>
         <p class="folder-path">{folderPath}</p>
-        <p>If you want to see the content of this folder:</p>
-        <ol>
-            <li>Click <strong>Open System Settings</strong> below</li>
-            <li>Click <strong>Files & Folders</strong> in the list</li>
-            <li>Find <strong>Cmdr</strong> and toggle the switch for this folder.</li>
-            <li>Confirm it and click <strong>Quit & Reopen</strong></li>
-        </ol>
-        <div class="cta">
-            <Button variant="primary" onclick={() => openPrivacySettings()}>Open System Settings</Button>
-        </div>
+        {#if isMacOS()}
+            <p>If you want to see the content of this folder:</p>
+            <ol>
+                <li>Click <strong>Open System Settings</strong> below</li>
+                <li>Click <strong>Files & Folders</strong> in the list</li>
+                <li>Find <strong>Cmdr</strong> and toggle the switch for this folder.</li>
+                <li>Confirm it and click <strong>Quit & Reopen</strong></li>
+            </ol>
+            <div class="cta">
+                <Button variant="primary" onclick={() => openPrivacySettings()}>Open System Settings</Button>
+            </div>
+        {:else}
+            <p>You don't have permission to read this folder. Check that your user has the right file permissions.</p>
+        {/if}
     </div>
 </div>