E2E: open windows without stealing OS focus

- Viewer and Settings windows open with `focus: false` when running under `CMDR_E2E_MODE=1`. The plugin drives the DOM via the Unix socket and doesn't need OS focus.
- Settings re-open path skips the `focus-self` event in E2E too, so reopening an already-open Settings window doesn't grab focus either.
- macOS `show_main_window` uses `[NSWindow orderFront:]` instead of `makeKeyAndOrderFront:` in E2E, so the initial main-window appearance doesn't steal focus from whatever the user is working in.
- Prod/dev behavior unchanged.

Author: vdavid

apps/desktop/src-tauri/src/commands/ui.rs

@@ -118,6 +118,24 @@ pub fn show_breadcrumb_context_menu<R: Runtime>(window: Window<R>, shortcut: Str
 #[tauri::command]
 #[specta::specta]
 pub fn show_main_window<R: Runtime>(window: Window<R>) -> Result<(), String> {
+    // E2E: on macOS, use `orderFront:` instead of `makeKeyAndOrderFront:` so the
+    // window appears without stealing focus from whatever the user is currently
+    // working in. `window.show()` calls the latter on macOS, which always grabs
+    // OS focus. Linux/Windows test runs happen in headless containers, so the
+    // standard show is fine there.
+    #[cfg(target_os = "macos")]
+    if crate::test_mode::is_e2e_mode() {
+        use objc2::msg_send;
+        use objc2::runtime::AnyObject;
+        let ns_window = window.ns_window().map_err(|e| e.to_string())? as *mut AnyObject;
+        if ns_window.is_null() {
+            return Err("NSWindow pointer is null".into());
+        }
+        unsafe {
+            let _: () = msg_send![ns_window, orderFront: std::ptr::null_mut::<AnyObject>()];
+        }
+        return Ok(());
+    }
     window.show().map_err(|e| e.to_string())
 }
 

apps/desktop/src/lib/file-viewer/open-viewer.ts

@@ -1,12 +1,17 @@
 /** Opens a file viewer window for the given file path. Multiple viewers can be open at once. */
 export async function openFileViewer(filePath: string): Promise<void> {
   const { WebviewWindow } = await import('@tauri-apps/api/webviewWindow')
-  const { decorateChildWindowTitle } = await import('$lib/app-mode')
+  const { decorateChildWindowTitle, getAppMode } = await import('$lib/app-mode')
 
   // Use a unique label per viewer instance (timestamp-based)
   const label = `viewer-${String(Date.now())}`
   const encodedPath = encodeURIComponent(filePath)
 
+  // E2E suites open viewer windows repeatedly; stealing OS focus each time
+  // makes the host machine unusable while tests run. The plugin reaches the
+  // webview over a Unix socket, so it doesn't need OS focus to drive the DOM.
+  const isE2e = getAppMode() === 'e2e'
+
   new WebviewWindow(label, {
     url: `/viewer?path=${encodedPath}`,
     title: decorateChildWindowTitle(filePath.split('/').pop() ?? 'Viewer'),
@@ -18,6 +23,6 @@ export async function openFileViewer(filePath: string): Promise<void> {
     minimizable: true,
     maximizable: true,
     closable: true,
-    focus: true,
+    focus: !isE2e,
   })
 }

apps/desktop/src/lib/settings/settings-window.ts

@@ -21,7 +21,7 @@ import { WebviewWindow } from '@tauri-apps/api/webviewWindow'
 import { emitTo } from '@tauri-apps/api/event'
 import { getAppLogger } from '$lib/logging/logger'
 import { getEffectiveScale } from '$lib/text-size.svelte'
-import { decorateChildWindowTitle } from '$lib/app-mode'
+import { decorateChildWindowTitle, getAppMode } from '$lib/app-mode'
 
 const log = getAppLogger('settings')
 
@@ -54,11 +54,18 @@ export const settingsMaxWidth = (scale: number): number =>
  * the matching section path (e.g., `['File systems', 'SMB/Network shares']`).
  */
 export async function openSettingsWindow(section?: string[]): Promise<void> {
+  // E2E suites re-open Settings many times; stealing OS focus each time
+  // makes the host machine unusable while tests run. The plugin reaches the
+  // webview over a Unix socket, so it doesn't need OS focus to drive the DOM.
+  const isE2e = getAppMode() === 'e2e'
+
   const existing = await WebviewWindow.getByLabel('settings')
   if (existing) {
     // Emit to the settings window so it can self-focus. Cross-window setFocus()
     // doesn't reliably bring a window to front on macOS.
-    await emitTo('settings', 'focus-self')
+    if (!isE2e) {
+      await emitTo('settings', 'focus-self')
+    }
     if (section) {
       await emitTo('settings', 'navigate-to-section', { section })
     }
@@ -84,6 +91,6 @@ export async function openSettingsWindow(section?: string[]): Promise<void> {
     center: true,
     resizable: true,
     decorations: true,
-    focus: true,
+    focus: !isE2e,
   })
 }