Strip em dashes from docs and comments (45 files, 327 occurrences)

Author: vdavid

apps/api-server/src/error-report-eviction.test.ts

@@ -231,7 +231,7 @@ describe('tryEvict', () => {
 
   it('evicts oldest by key date prefix, then upload time for ties', async () => {
     const objs: StubObj[] = [
-      // Same day — two uploads with different upload times
+      // Same day: two uploads with different upload times
       {
         key: `${ERROR_REPORT_PREFIX}2026-04-01/ERR-AAAAA-u.zip`,
         size: 2 * GB,

apps/desktop/src-tauri/src/commands/e2e.rs

@@ -2,7 +2,7 @@
 
 /// Returns the `CMDR_E2E_START_PATH` env var if set.
 /// The frontend uses this to override startup paths for E2E tests.
-/// Always compiled in — reading an unset env var is a no-op in production.
+/// Always compiled in. Reading an unset env var is a no-op in production.
 #[tauri::command]
 #[specta::specta]
 pub fn get_e2e_start_path() -> Option<String> {
@@ -27,7 +27,7 @@ pub fn set_test_throttle(ms: Option<u64>) -> Result<(), String> {
 ///
 /// The notify-debouncer-full crate buffers events for `DEBOUNCE_MS` (200 ms by
 /// default), plus the OS itself coalesces FSEvents on macOS over a longer
-/// window — so a single FS mutation can take 1–10 s to land in the UI. For
+/// window, so a single FS mutation can take 1–10 s to land in the UI. For
 /// tests, that's pure waste.
 ///
 /// This command sidesteps the debouncer: it iterates every active listing and

apps/desktop/src-tauri/src/commands/search.rs

@@ -46,7 +46,7 @@ pub async fn prepare_search_index(app: tauri::AppHandle) -> Result<PrepareResult
                     h.abort();
                 }
                 state.idle_timer = None;
-                // Reset backstop timer — the previous session's timer may still
+                // Reset backstop timer; the previous session's timer may still
                 // be ticking and could fire while the dialog is open.
                 if let Some(ref h) = state.backstop_timer {
                     h.abort();
@@ -57,7 +57,7 @@ pub async fn prepare_search_index(app: tauri::AppHandle) -> Result<PrepareResult
                     entry_count: state.index.entries.len() as u64,
                 });
             }
-            // Stale — drop and reload below
+            // Stale: drop and reload below
         }
     }
 
@@ -204,7 +204,7 @@ pub async fn search_files(mut query: SearchQuery) -> Result<SearchResult, String
             }
             true
         });
-        // total_count is approximate after post-filtering — the true count
+        // total_count is approximate after post-filtering; the true count
         // would require fetching dir_stats for ALL matching directories, which
         // is too expensive. The displayed count may overestimate slightly.
         result.total_count = result.entries.len() as u32;
@@ -216,7 +216,7 @@ pub async fn search_files(mut query: SearchQuery) -> Result<SearchResult, String
         result.entries.truncate(limit);
     }
 
-    // Check generation staleness — trigger background reload if needed
+    // Check generation staleness; trigger background reload if needed
     let current_gen = WRITER_GENERATION.load(Ordering::Relaxed);
     if index.generation != current_gen {
         log::debug!(

apps/desktop/src-tauri/src/commands/volumes.rs

@@ -9,7 +9,7 @@ use crate::volumes::{self, DEFAULT_VOLUME_ID, LocationCategory, VolumeInfo, Volu
 
 /// Result of resolving a path to its containing volume.
 /// Unlike `TimedOut<Option<VolumeInfo>>`, `timed_out: true` means "the filesystem
-/// didn't respond, we genuinely don't know" — not "here's a fallback."
+/// didn't respond, we genuinely don't know" (not "here's a fallback").
 #[derive(Debug, Clone, Serialize, specta::Type)]
 #[serde(rename_all = "camelCase")]
 pub struct PathVolumeResolution {

apps/desktop/src-tauri/src/error_reporter/bundle_builder.rs

@@ -8,7 +8,7 @@
 //!   timestamp, packs into a `BTreeMap`, then calls [`build_zip`].
 //!
 //! Public entry point is [`build_bundle`], which dispatches on the scope. Capping is in
-//! the sibling [`super::bundle_capper`] module — Flow A enforces the cap inline, Flow B
+//! the sibling [`super::bundle_capper`] module. Flow A enforces the cap inline; Flow B
 //! relies on a post-build trim from the auto-dispatcher.
 
 use super::tail_walker;
@@ -36,7 +36,7 @@ const SAMPLE_LAST_LINES: usize = 20;
 const FLOW_B_PRE_ERROR_WINDOW: chrono::Duration = chrono::Duration::minutes(30);
 
 /// One log file selected for inclusion: redacted lines plus the source file's mtime
-/// (used to date the zip entry — without an explicit mtime, `zip` writes 1980-01-01).
+/// (used to date the zip entry; without an explicit mtime, `zip` writes 1980-01-01).
 #[derive(Debug, Clone)]
 pub(super) struct PreparedFile {
     pub(super) lines: Vec<String>,
@@ -46,7 +46,7 @@ pub(super) struct PreparedFile {
 /// Build an error report bundle in memory. No network. No disk writes (except reading logs).
 ///
 /// `user_note` is trimmed and dropped if empty. Callers are expected to cap its length
-/// (the commands layer enforces 100 000 chars) — we store it verbatim.
+/// (the commands layer enforces 100 000 chars); we store it verbatim.
 ///
 /// `scope` controls which log content makes it into the bundle. See [`BundleScope`].
 ///
@@ -202,7 +202,7 @@ pub(super) fn build_bundle_streaming(
 
         if walk.lines.is_empty() {
             // If we bailed at the cutoff with no lines, older rotations would be
-            // older still — stop walking entirely.
+            // older still. Stop walking entirely.
             if walk.hit_cutoff {
                 break;
             }
@@ -241,7 +241,7 @@ pub(super) fn build_bundle_streaming(
 
             // Mid-file cap check. The deflater holds an internal buffer of up to ~64 KB
             // that hasn't been flushed to the cursor yet, so the counter is a lower
-            // bound on the eventual on-disk size — there's a small overshoot risk on
+            // bound on the eventual on-disk size. There's a small overshoot risk on
             // the order of one chunk + the central directory tail (~few hundred bytes
             // per entry). Both are well inside the cap's headroom.
             let bytes_so_far = counter.load(std::sync::atomic::Ordering::Relaxed) as usize;
@@ -279,7 +279,7 @@ pub(super) fn build_bundle_streaming(
 /// `Write::write` call. Lets the streaming zip pipeline poll the running compressed
 /// byte count without taking an unsafe `get_mut()` borrow on the `ZipWriter`.
 ///
-/// The counter measures bytes the `zip` crate emitted to the cursor — i.e. compressed
+/// The counter measures bytes the `zip` crate emitted to the cursor, i.e. compressed
 /// payload + per-entry headers up to the last deflate flush. The crate's internal
 /// deflate buffer (up to ~64 KB) lags behind, so callers should treat the counter as a
 /// lower bound on the final size and budget conservatively.
@@ -331,7 +331,7 @@ fn build_bundle_legacy_window(
     now_system: SystemTime,
     salt: &[u8],
 ) -> Result<BuiltBundle, String> {
-    // BTreeMap so zip order is deterministic — same inputs, same bytes out. Matters for
+    // BTreeMap so zip order is deterministic: same inputs, same bytes out. Matters for
     // the preview hash and for byte-level tests.
     let mut prepared: BTreeMap<String, PreparedFile> = BTreeMap::new();
     let mut total_redacted_lines: usize = 0;
@@ -386,7 +386,7 @@ fn build_bundle_legacy_window(
 ///
 /// Returns `None` if the file can't be opened or its mtime can't be read; returns
 /// `Some((lines, mtime))` otherwise. `lines` may be empty if the entire file was
-/// outside the scope window — callers drop empty results so the bundle doesn't ship
+/// outside the scope window. Callers drop empty results so the bundle doesn't ship
 /// empty `logs/<name>` entries.
 pub(super) fn load_and_filter_log_file(
     path: &Path,
@@ -409,7 +409,7 @@ pub(super) fn load_and_filter_log_file(
     let mtime = metadata.modified().unwrap_or(now_system);
 
     // File-level filter. If a file's mtime is older than the lower bound of the scope's
-    // window, skip it entirely — its newest line is older than what we want.
+    // window, skip it entirely: its newest line is older than what we want.
     let lower_bound = match scope {
         BundleScope::Recent { window } => {
             now_utc - chrono::Duration::from_std(window).unwrap_or(chrono::Duration::hours(1))
@@ -436,7 +436,7 @@ pub(super) fn load_and_filter_log_file(
 
     // Per-line filter for the Flow B window: drop lines whose leading ISO-8601 stamp
     // is older than `lower_bound`. Lines without a parseable stamp pass through (the
-    // log line wasn't written by us — we keep it as-is rather than risk dropping
+    // log line wasn't written by us, so we keep it as-is rather than risk dropping
     // something useful).
     let mut lines: Vec<String> = Vec::new();
     for line in reader.lines().map_while(Result::ok) {
@@ -454,7 +454,7 @@ pub(super) fn load_and_filter_log_file(
 
 /// Convert a [`SystemTime`] into a [`zip::DateTime`] (the format the zip crate stores
 /// per entry). On parse failure (system clock before 1980, post-2107) returns the zip
-/// crate's default — not a hard error; the bundle still ships, just with a placeholder
+/// crate's default (not a hard error). The bundle still ships, just with a placeholder
 /// mtime on that one entry.
 pub(super) fn zip_dt(time: SystemTime) -> ZipDateTime {
     let local: DateTime<chrono::Local> = time.into();
@@ -473,8 +473,8 @@ pub(super) fn zip_dt(time: SystemTime) -> ZipDateTime {
 ///
 /// Each entry's mtime is set explicitly: `manifest.json` uses `now`, log entries use
 /// the source file's mtime. Without this, the `zip` crate writes 1980-01-01 00:00 for
-/// every entry (DOS epoch), which makes downstream tooling — and humans inspecting the
-/// archive — unable to tell when anything was actually captured.
+/// every entry (DOS epoch), which makes downstream tooling and humans inspecting the
+/// archive unable to tell when anything was actually captured.
 ///
 /// Split out from [`build_bundle`] so tests can feed synthetic inputs without needing
 /// a Tauri app handle or a real log directory.

apps/desktop/src-tauri/src/file_system/cloud_actions.rs

@@ -1,10 +1,10 @@
-//! "Make available offline" / "Remove download" wrappers — iCloud Drive only.
+//! "Make available offline" / "Remove download" wrappers (iCloud Drive only).
 //!
-//! Implementation notes — important context for future agents:
+//! Implementation notes (important context for future agents):
 //!
 //! `NSFileProviderManager` looked like the universal cross-provider API (Dropbox,
 //! Google Drive, OneDrive, Box, iCloud all show up as File Provider domains since
-//! macOS 12.3). It isn't — its host-side methods (`getDomainsWithCompletionHandler`,
+//! macOS 12.3). It isn't: its host-side methods (`getDomainsWithCompletionHandler`,
 //! `evictItemWithIdentifier`, `requestDownloadForItemWithIdentifier`) are reserved
 //! for the app that *bundles* the File Provider extension. From a third-party app
 //! like Cmdr, the system rejects the call with `NSFileProviderErrorProviderNotFound`
@@ -13,7 +13,7 @@
 //!
 //! What does work for any app: `FileManager.evictUbiquitousItem(at:)` and
 //! `startDownloadingUbiquitousItem(at:)`. They route through the **iCloud (NSUbiquity)
-//! infrastructure** — separate from the File Provider host APIs above — and accept
+//! infrastructure**, separate from the File Provider host APIs above, and accept
 //! any URL inside an iCloud ubiquity container. So we offer the eviction / download
 //! menu items only for files under `~/Library/Mobile Documents/com~apple~CloudDocs/`
 //! (iCloud Drive). For Dropbox/GDrive/OneDrive items the menu items don't appear;
@@ -32,7 +32,7 @@ fn home_dir() -> Option<PathBuf> {
     std::env::var_os("HOME").map(PathBuf::from)
 }
 
-/// Returns true only for paths inside iCloud Drive — the location where
+/// Returns true only for paths inside iCloud Drive, the location where
 /// `FileManager.evictUbiquitousItem` / `startDownloadingUbiquitousItem` work.
 #[cfg(target_os = "macos")]
 pub fn is_in_icloud_drive(path: &Path) -> bool {
@@ -150,7 +150,7 @@ mod tests {
     #[test]
     fn is_in_icloud_drive_excludes_third_party() {
         set_test_home();
-        // Third-party clouds aren't iCloud — eviction APIs don't apply.
+        // Third-party clouds aren't iCloud, so eviction APIs don't apply.
         assert!(!is_in_icloud_drive(Path::new(
             "/Users/test/Library/CloudStorage/Dropbox/foo.txt"
         )));

apps/desktop/src-tauri/src/file_system/listing/caching.rs

@@ -22,7 +22,7 @@ pub enum DirectoryChange {
     Modified(FileEntry),
     /// An entry was renamed within the same directory.
     Renamed { old_name: String, new_entry: FileEntry },
-    /// Unknown or bulk change — trigger a full re-read via the Volume trait.
+    /// Unknown or bulk change: trigger a full re-read via the Volume trait.
     FullRefresh,
 }
 
@@ -58,7 +58,7 @@ pub(crate) struct CachedListing {
     /// Lives on the listing so it works for all volume types, including SMB/MTP
     /// which don't use the FSEvents-based `WatchedDirectory`.
     pub sequence: AtomicU64,
-    /// When this listing was created. Used by `snapshot_listings` for triage —
+    /// When this listing was created. Used by `snapshot_listings` for triage,
     /// surfacing orphan listings (e.g., volume dropdown previews) in error reports.
     pub created_at: Instant,
 }
@@ -73,8 +73,8 @@ pub struct ListingSummary {
 }
 
 /// Returns a snapshot of every active listing in the cache. Used by `cmdr://state`
-/// so triagers can spot orphan listings (started but never bound to a pane —
-/// for example, when a volume dropdown commits a navigation that the user then
+/// so triagers can spot orphan listings (started but never bound to a pane,
+/// for example when a volume dropdown commits a navigation that the user then
 /// abandons or that surfaces an error).
 pub fn snapshot_listings() -> Vec<ListingSummary> {
     let cache = match LISTING_CACHE.read() {

apps/desktop/src-tauri/src/file_viewer/byte_seek_test.rs

@@ -321,7 +321,7 @@ fn backward_scan_with_no_newline_caps_at_max() {
 
     let backend = ByteSeekBackend::open(&file).unwrap();
 
-    // Seek to byte 15000 — backward scan of 8192 bytes won't find '\n'
+    // Seek to byte 15000; backward scan of 8192 bytes won't find '\n'
     let chunk = backend.get_lines(&SeekTarget::ByteOffset(15000), 1).unwrap();
 
     // Should fall back to scan_start = 15000 - 8192 = 6808

apps/desktop/src-tauri/src/file_viewer/line_index.rs

@@ -1,7 +1,7 @@
-//! LineIndexBackend — sparse line-offset index for efficient line-based seeking.
+//! LineIndexBackend: sparse line-offset index for efficient line-based seeking.
 //!
 //! Stores byte offsets every INDEX_CHECKPOINT_INTERVAL lines (256 by default).
-//! Memory: O(total_lines / 256) — a 10M-line file uses ~40 KB of index.
+//! Memory: O(total_lines / 256); a 10M-line file uses ~40 KB of index.
 //!
 //! The index is built by scanning the file for newlines using memchr (SIMD-accelerated).
 //! After scanning, supports O(1) line-based seeking via the checkpoint array.
@@ -102,7 +102,7 @@ impl LineIndexBackend {
         }
 
         // total_lines is line_number + 1 (for the last line, which may not end with \n)
-        // But if the file ends with \n, the last "line" is empty — we still count it.
+        // But if the file ends with \n, the last "line" is empty; we still count it.
         let total_lines = line_number + 1;
 
         Ok(Self {
@@ -217,7 +217,7 @@ impl FileViewerBackend for LineIndexBackend {
 
         let lines = self.read_lines_from_checkpoint(checkpoint.offset, lines_to_skip, count)?;
 
-        // Calculate byte offset of the target line (approximate — it's the checkpoint offset)
+        // Calculate byte offset of the target line (approximate; it's the checkpoint offset)
         let byte_offset = checkpoint.offset;
 
         Ok(LineChunk {
@@ -315,7 +315,7 @@ impl FileViewerBackend for LineIndexBackend {
             *progress.lock_ignore_poison() = scanned;
         }
 
-        // Handle last line (only reached if limit not hit — loop breaks early otherwise)
+        // Handle last line (only reached if limit not hit; loop breaks early otherwise)
         if !leftover.is_empty() {
             let line = String::from_utf8_lossy(&leftover);
             let line_lower = line.to_lowercase();

apps/desktop/src-tauri/src/file_viewer/mod.rs

@@ -1,4 +1,4 @@
-//! File viewer module — on-demand line serving with three backend strategies.
+//! File viewer module: on-demand line serving with three backend strategies.
 //!
 //! Backends:
 //! - `FullLoadBackend`: loads entire file into memory (small files, <1 MB)
@@ -37,7 +37,7 @@ const MAX_BACKWARD_SCAN: usize = 8192;
 
 /// Maximum number of matches stored during search. Once reached, the search stops entirely.
 /// The frontend highlights additional matches client-side on visible lines, so stopping early
-/// doesn't lose highlighting — it only caps the prev/next navigation index.
+/// doesn't lose highlighting: it only caps the prev/next navigation index.
 const MAX_SEARCH_MATCHES: usize = 10_000;
 
 /// Where to seek in the file.