Skip to content

Commit c6210ae

Browse files
vdavidvdavid
committed
Testing: Remove desktop smoke tests
- Smoke tests ran Playwright in a browser (not Tauri webview), testing a degraded fallback path no real user encounters - The same UI rendering and focus-switching behavior is already covered by Vitest integration tests and Linux E2E - Removes `test/e2e-smoke/`, `playwright.config.ts`, `desktop-svelte-smoke.go`, `@playwright/test` dep, CI step, and updates docs
1 parent 4079332 commit c6210ae

11 files changed

Lines changed: 8 additions & 170 deletions

File tree

‎.github/workflows/ci.yml‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -174,13 +174,6 @@ jobs:
174174
- name: Run Svelte tests
175175
run: ./scripts/check/check --check desktop-svelte-tests --ci
176176

177-
- name: Install Playwright browsers
178-
run: pnpm exec playwright install --with-deps chromium webkit
179-
working-directory: ./apps/desktop
180-
181-
- name: Run E2E tests
182-
run: ./scripts/check/check --check desktop-svelte-smoke --ci
183-
184177
# ===========================================
185178
# Desktop app - Tauri E2E (Linux)
186179
# ===========================================

‎AGENTS.md‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ Core structure:
2222
- `/apps/`
2323
- `analytics-dashboard/` - Private metrics dashboard (SvelteKit + CF Pages)
2424
- `desktop/` - The Tauri desktop app
25-
- `test/e2e-smoke/` - Playwright smoke tests (browser-based, works on macOS)
2625
- `test/e2e-linux/` - WebDriverIO + tauri-driver tests (Docker, tests real Tauri app)
2726
- `src/` - Svelte frontend. Uses SvelteKit with static adapter. TypeScript strict mode. Tailwind v4.
2827
- `lib/` - Components

‎apps/desktop/package.json‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
"test": "vitest run",
2121
"test:coverage": "vitest run --coverage",
2222
"test:watch": "vitest",
23-
"test:e2e:smoke": "playwright test",
2423
"test:e2e:linux": "./scripts/e2e-linux.sh",
2524
"test:e2e:linux:native": "wdio run test/e2e-linux/wdio.conf.ts",
2625
"test:e2e:linux:build": "docker build -t cmdr-e2e -f test/e2e-linux/docker/Dockerfile test/e2e-linux/docker",
@@ -52,7 +51,6 @@
5251
"@crabnebula/tauri-driver": "^2.0.9",
5352
"@crabnebula/test-runner-backend": "^0.2.6",
5453
"@eslint/js": "^9.39.3",
55-
"@playwright/test": "^1.58.2",
5654
"@sveltejs/adapter-static": "^3.0.10",
5755
"@sveltejs/kit": "^2.53.4",
5856
"@sveltejs/vite-plugin-svelte": "^6.2.4",

‎apps/desktop/playwright.config.ts‎

Lines changed: 0 additions & 34 deletions
This file was deleted.

‎apps/desktop/test/CLAUDE.md‎

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,18 +2,17 @@
22

33
## E2E test suites
44

5-
Three complementary approaches, each covering what the others can't:
5+
Two complementary approaches, each covering what the others can't:
66

7-
| Suite | Tech | Runs on | What it tests | CI? |
8-
| ---------------------------- | ---------------------------- | --------------- | ----------------------------------------------------------- | ---------------------- |
9-
| **Smoke** (`e2e-smoke/`) | Playwright (Chromium/WebKit) | macOS, Linux | UI renders correctly (no Tauri backend) | Yes |
10-
| **Linux E2E** (`e2e-linux/`) | WebDriverIO + tauri-driver | Docker (Ubuntu) | Full app: dialogs, keyboard nav, file ops, settings, viewer | Yes (slow) |
11-
| **macOS E2E** (`e2e-macos/`) | WebDriverIO + CrabNebula | macOS only | Platform integration: APFS ops, volume detection, WKWebView | No (local pre-release) |
7+
| Suite | Tech | Runs on | What it tests | CI? |
8+
| ---------------------------- | -------------------------- | --------------- | ----------------------------------------------------------- | ---------------------- |
9+
| **Linux E2E** (`e2e-linux/`) | WebDriverIO + tauri-driver | Docker (Ubuntu) | Full app: dialogs, keyboard nav, file ops, settings, viewer | Yes (slow) |
10+
| **macOS E2E** (`e2e-macos/`) | WebDriverIO + CrabNebula | macOS only | Platform integration: APFS ops, volume detection, WKWebView | No (local pre-release) |
1211

1312
**Why separate?** macOS WKWebView has no Apple-provided WebDriver, so standard tauri-driver only works on Linux
1413
(WebKitGTK has WebKitWebDriver). CrabNebula provides a commercial WKWebView bridge for macOS, but GitHub Actions charges
1514
macOS minutes at 10x — too expensive for CI. So: Linux E2E is the workhorse (all platform-independent logic), macOS E2E
16-
covers platform-specific behavior, and smoke tests catch UI regressions without needing a Tauri build.
15+
covers platform-specific behavior.
1716

1817
## Shared fixture system
1918

‎apps/desktop/test/e2e-linux/CLAUDE.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ The Docker container (`docker/Dockerfile`) includes: Ubuntu 24.04, WebKitGTK run
6161
Most common operation: `docker volume rm cmdr-target-cache` after Rust/Svelte changes.
6262

6363
Why two node_modules volumes? Both must be Docker volumes to prevent Linux binaries from contaminating the host's
64-
node_modules (which would break macOS smoke tests).
64+
node_modules.
6565

6666
### Interactive debugging
6767

‎apps/desktop/test/e2e-smoke/smoke.test.ts‎

Lines changed: 0 additions & 77 deletions
This file was deleted.

‎pnpm-lock.yaml‎

Lines changed: 0 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎scripts/check/CLAUDE.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ tests, type checkers before tests.
157157
| App | Tech | Checks |
158158
|-----|------|--------|
159159
| Desktop | Rust | rustfmt, clippy, cargo-audit, cargo-deny, cargo-udeps, jscpd, tests, tests-linux (slow) |
160-
| Desktop | Svelte | prettier, eslint, stylelint, css-unused, svelte-check, import-cycles, knip, type-drift, tests, smoke, e2e-linux-typecheck, e2e-linux (slow) |
160+
| Desktop | Svelte | prettier, eslint, stylelint, css-unused, svelte-check, import-cycles, knip, type-drift, tests, e2e-linux-typecheck, e2e-linux (slow) |
161161
| Website | Astro | prettier, eslint, typecheck, build, html-validate, e2e |
162162
| Website | Docker | docker-build |
163163
| License server | TS | prettier, eslint, typecheck, tests |

‎scripts/check/checks/desktop-svelte-smoke.go‎

Lines changed: 0 additions & 28 deletions
This file was deleted.

0 commit comments

Comments
 (0)