Settings: rename settings-v2.json to settings.json

- No users on the old v1 format, so remove the fallback cascade
- Rename `parse_settings_v2` → `parse_settings`
- Update all docs and CLAUDE.md files

Author: vdavid

apps/desktop/src-tauri/src/settings/CLAUDE.md

@@ -7,7 +7,7 @@ Thin read-only settings loader used during Rust startup. The frontend owns all s
 | File | Purpose |
 |---|---|
 | `mod.rs` | Re-exports `load_settings` from `legacy` |
-| `legacy.rs` | `Settings` struct + `load_settings`: tries `settings-v2.json` first, falls back to `settings.json`, then uses defaults |
+| `legacy.rs` | `Settings` struct + `load_settings`: reads `settings.json`, falls back to defaults |
 
 ## Settings struct
 
@@ -21,35 +21,30 @@ Settings {
 }
 ```
 
-## File formats
+## File format
 
-**`settings-v2.json`** (current): flat JSON with literal dot-notation string keys.
+**`settings.json`**: flat JSON with literal dot-notation string keys, written by `tauri-plugin-store`.
 
 ```json
 { "showHiddenFiles": true, "developer.mcpEnabled": true, "developer.mcpPort": 9224 }
 ```
 
-These are top-level keys — the dot is part of the key name, not a nesting separator. `parse_settings_v2` reads them manually (serde can't express dot-notation field names as struct fields).
-
-**`settings.json`** (legacy): nested JSON with camelCase keys, parsed via serde aliases.
+These are top-level keys — the dot is part of the key name, not a nesting separator. `parse_settings` reads them manually (serde can't express dot-notation field names as struct fields).
 
 ## Key decisions
 
 **Decision**: Rust reads the settings file directly instead of receiving values via IPC from the frontend.
 **Why**: Several backend systems (MCP server, hidden files filter, indexing) need their config *before* any frontend window loads. Waiting for the frontend to boot and push settings would create a race condition or require delaying backend initialization. Reading the file directly means the backend is configured immediately at launch.
 
-**Decision**: Manual JSON field extraction in `parse_settings_v2` instead of serde auto-derivation.
+**Decision**: Manual JSON field extraction in `parse_settings` instead of serde auto-derivation.
 **Why**: `tauri-plugin-store` writes flat JSON with literal dot-notation string keys like `"developer.mcpEnabled"`. Serde's `rename` attribute can handle this per-field, but the dot is part of the key name, not a nesting separator. The manual extraction makes this non-obvious format explicit and avoids confusion about nested vs. flat structure.
 
-**Decision**: Try `settings-v2.json` first, then fall back to `settings.json`, then defaults.
-**Why**: The app migrated from a nested JSON format (v1) to the flat dot-notation format (v2) written by `tauri-plugin-store`. Users upgrading from older versions still have the v1 file. The cascade ensures settings survive across app updates without requiring an explicit migration step.
-
 ## Key patterns
 
 - **One-way read only.** This module never writes. All writes go through the frontend's settings store.
 - Module is named `legacy` because ideally the frontend would push relevant values via IPC at startup rather than requiring Rust to parse the store file directly.
 - `full_disk_access_choice` is marked `#[allow(dead_code)]` — it is persisted by the frontend but the backend takes no action on it.
-- Falls back gracefully at every step: missing file → try next format → use `Default`.
+- Falls back gracefully: missing file → use `Default`.
 
 ## Dependencies
 

apps/desktop/src-tauri/src/settings/legacy.rs

@@ -1,6 +1,6 @@
 //! Settings loading from tauri-plugin-store JSON file.
 //!
-//! Reads settings from the settings-v2.json file created by tauri-plugin-store.
+//! Reads settings from the settings.json file created by tauri-plugin-store.
 //! Used to initialize app state (menu checkboxes, MCP config) on startup.
 
 use serde::Deserialize;
@@ -21,7 +21,7 @@ pub enum FullDiskAccessChoice {
 }
 
 /// User settings structure, matching the frontend settings-store.ts
-/// Note: Uses serde aliases to support both camelCase (settings-v2.json) and snake_case
+/// Note: Uses serde aliases to support both camelCase (settings.json) and snake_case
 #[derive(Debug, Deserialize)]
 pub struct Settings {
     #[serde(alias = "showHiddenFiles", default = "default_show_hidden")]
@@ -53,35 +53,26 @@ impl Default for Settings {
     }
 }
 
-/// Loads settings from the persistent store file (settings-v2.json).
+/// Loads settings from the persistent store file (settings.json).
 /// Returns defaults if the file doesn't exist or can't be parsed.
 pub fn load_settings<R: tauri::Runtime>(app: &tauri::AppHandle<R>) -> Settings {
     // Get the app data directory (like ~/Library/Application Support/com.veszelovszki.cmdr/)
     let Some(data_dir) = crate::config::resolved_app_data_dir(app).ok() else {
         return Settings::default();
     };
 
-    // Try settings-v2.json first (new format from tauri-plugin-store)
-    let settings_v2_path: PathBuf = data_dir.join("settings-v2.json");
-    if let Ok(contents) = fs::read_to_string(&settings_v2_path)
-        && let Ok(settings) = parse_settings_v2(&contents)
-    {
-        return settings;
-    }
-
-    // Fall back to legacy settings.json
     let settings_path: PathBuf = data_dir.join("settings.json");
     if let Ok(contents) = fs::read_to_string(&settings_path)
-        && let Ok(settings) = serde_json::from_str(&contents)
+        && let Ok(settings) = parse_settings(&contents)
     {
         return settings;
     }
 
     Settings::default()
 }
 
-/// Parse settings-v2.json which uses dot notation for keys (like "developer.mcpEnabled")
-fn parse_settings_v2(contents: &str) -> Result<Settings, serde_json::Error> {
+/// Parse settings.json which uses dot notation for keys (like "developer.mcpEnabled")
+fn parse_settings(contents: &str) -> Result<Settings, serde_json::Error> {
     // tauri-plugin-store uses flat JSON with dot notation keys
     let json: serde_json::Value = serde_json::from_str(contents)?;
 

apps/desktop/src/lib/logging/logger.ts

@@ -64,7 +64,7 @@ let loggerInitialized = false
 async function getVerboseLoggingSetting(): Promise<boolean> {
     try {
         // Use empty defaults since we just want to read existing values
-        const store: Store = await load('settings-v2.json', {
+        const store: Store = await load('settings.json', {
             autoSave: false,
             defaults: {},
         })

apps/desktop/src/lib/settings/CLAUDE.md

@@ -20,7 +20,7 @@ Single source of truth for all settings. Each `SettingDefinition` contains:
 
 ### Store (`settings-store.ts`)
 
-- Uses `tauri-plugin-store` for persistence to `~/Library/Application Support/com.veszelovszki.cmdr/settings-v2.json`
+- Uses `tauri-plugin-store` for persistence to `~/Library/Application Support/com.veszelovszki.cmdr/settings.json`
 - Debounced saves: 500ms after last change, atomic write (temp file + rename)
 - In-memory cache for synchronous reads via `getSetting()`
 - Cross-window sync: emits `settings:changed` events when values change

apps/desktop/src/lib/settings/settings-store.ts

@@ -23,7 +23,7 @@ interface SettingChangedPayload {
 // Store Configuration
 // ============================================================================
 
-const STORE_NAME = 'settings-v2.json'
+const STORE_NAME = 'settings.json'
 const SCHEMA_VERSION = 1
 
 let storeInstance: Store | null = null

docs/architecture.md

@@ -210,7 +210,7 @@ zero-permission entries with fallback metadata.
 ### Persistence
 
 - **App status** (`app-status.json`): ephemeral state — paths, focused pane, view modes, last-used paths per volume
-- **Settings** (`settings-v2.json`): preferences — hidden files, density, date format. Registry-validated.
+- **Settings** (`settings.json`): preferences — hidden files, density, date format. Registry-validated.
 - **Shortcuts** (`shortcuts.json`): delta-only — only customizations stored, defaults in code
 - **License** (`license.json`): activation state, timestamps
 - **Window state**: `@tauri-apps/plugin-window-state` for size/position per window label