Skip to content

Commit f32dfc5

Browse files
committed
Onboarding: tidy FDA prompt typography and spacing
- Single body font size (`--font-size-md`) — previously the tip used `--font-size-sm`, breaking visual rhythm. - Tighter `line-height: 1.5` to match other dialogs in the app. - Consistent vertical rhythm via spacing tokens: `--spacing-md` between paragraphs, `--spacing-lg` between sections, `--spacing-sm` between list items. - Lists indented with `padding-left: var(--spacing-xl)` so bullets/numbers align cleanly. - Tip is now nested inside step 2 so the ordered list isn't broken visually (was making step 3 look orphaned). - Post-click hint sits under a thin top border with muted color — reads as a footnote, not a body re-skin. - Drop the old bold weight on the post-click "Great!" line; the message is calmer now.
1 parent 1691821 commit f32dfc5

1 file changed

Lines changed: 43 additions & 35 deletions

File tree

apps/desktop/src/lib/onboarding/FullDiskAccessPrompt.svelte

Lines changed: 43 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -69,14 +69,12 @@
6969
<p>It looks like you accepted full disk access before but then revoked it.</p>
7070
<p><strong>The app currently has no full disk access.</strong></p>
7171
<p>If that was intentional, click "Deny" and the app won't bother you again.</p>
72-
<p>If it <em>wasn't</em> intentional, consider allowing full disk access again.</p>
73-
<p>Here are the pros and cons:</p>
72+
<p>If it <em>wasn't</em> intentional, consider allowing full disk access again. Here are the pros and cons:</p>
7473
{:else}
75-
<p>Would you like to give this app full disk access?</p>
76-
<p>Here's what that means:</p>
74+
<p>Would you like to give this app full disk access? Here's what that means:</p>
7775
{/if}
7876

79-
<ul class="pros-cons">
77+
<ul class="bullets">
8078
<li>
8179
<strong>Pro:</strong> The app will access your entire disk without nagging you for permissions to each folder
8280
like Downloads, Documents, and Desktop.
@@ -89,25 +87,19 @@
8987

9088
<p>If you decide to allow:</p>
9189

92-
<ol>
90+
<ol class="steps">
9391
<li>Click <strong>Open System Settings</strong> below</li>
94-
{#if isVenturaOrNewer}
95-
<li>
92+
<li>
93+
{#if isVenturaOrNewer}
9694
Find <strong>Cmdr</strong> in the list and toggle it on
97-
<p class="step-tip">
98-
Tip: Is Cmdr not in the list? Click the "+" button at the bottom, and choose
99-
<strong>Cmdr</strong> from your <strong>Applications</strong> folder.
100-
</p>
101-
</li>
102-
{:else}
103-
<li>
95+
{:else}
10496
Find <strong>Cmdr</strong> at the end of the list and toggle it on
105-
<p class="step-tip">
106-
Tip: Is Cmdr not in the list? Click the "+" button at the bottom, and choose
107-
<strong>Cmdr</strong> from your <strong>Applications</strong> folder.
108-
</p>
109-
</li>
110-
{/if}
97+
{/if}
98+
<p class="step-tip">
99+
Tip: Is Cmdr not in the list? Click the "+" button at the bottom, and choose
100+
<strong>Cmdr</strong> from your <strong>Applications</strong> folder.
101+
</p>
102+
</li>
111103
<li>Confirm and click <strong>Quit & Reopen</strong></li>
112104
</ol>
113105

@@ -116,8 +108,10 @@
116108
<Button variant="danger" onclick={handleDeny}>Deny</Button>
117109
</div>
118110
{#if hasClickedOpenSettings}
119-
<p class="post-allow-instructions">Great! Make sure to restart the app after you've enabled the access.</p>
120-
<p>If you change your mind, you can still click "Deny" above.</p>
111+
<div class="post-action">
112+
<p>Make sure to restart the app after you've enabled the access.</p>
113+
<p>If you change your mind, you can still click "Deny" above.</p>
114+
</div>
121115
{/if}
122116
</div>
123117
</ModalDialog>
@@ -127,35 +121,49 @@
127121
padding: 0 var(--spacing-xl) var(--spacing-xl);
128122
font-size: var(--font-size-md);
129123
color: var(--color-text-primary);
130-
line-height: 1.6;
124+
line-height: 1.5;
131125
}
132126
133127
.fda-body p {
134128
margin: 0 0 var(--spacing-md) 0;
135129
}
136130
137-
.post-allow-instructions {
138-
font-weight: 500;
131+
.fda-body p:last-child {
132+
margin-bottom: 0;
139133
}
140134
141-
.step-tip {
142-
margin: var(--spacing-xs) 0 0 0;
143-
color: var(--color-text-secondary);
144-
font-size: var(--font-size-sm);
135+
.bullets,
136+
.steps {
137+
margin: 0 0 var(--spacing-lg) 0;
138+
padding-left: var(--spacing-xl);
145139
}
146140
147-
.pros-cons {
148-
margin: var(--spacing-lg) 0;
141+
.bullets li,
142+
.steps li {
143+
margin-bottom: var(--spacing-sm);
149144
}
150145
151-
.pros-cons li {
152-
margin-bottom: var(--spacing-md);
146+
.bullets li:last-child,
147+
.steps li:last-child {
148+
margin-bottom: 0;
149+
}
150+
151+
.step-tip {
152+
margin: var(--spacing-xs) 0 0 0;
153+
color: var(--color-text-secondary);
153154
}
154155
155156
.buttons {
156157
display: flex;
157158
gap: var(--spacing-md);
158159
justify-content: center;
159-
margin: var(--spacing-xl) 0;
160+
margin-top: var(--spacing-lg);
161+
}
162+
163+
.post-action {
164+
margin-top: var(--spacing-lg);
165+
padding-top: var(--spacing-lg);
166+
border-top: 1px solid var(--color-border-subtle);
167+
color: var(--color-text-secondary);
160168
}
161169
</style>

0 commit comments

Comments
 (0)