Skip to content

Fix/pty.js build#1001

Merged
matheuss merged 3 commits intomasterfrom
fix/pty.js-build
Nov 16, 2016
Merged

Fix/pty.js build#1001
matheuss merged 3 commits intomasterfrom
fix/pty.js-build

Conversation

@matheuss
Copy link
Member

@matheuss matheuss commented Nov 16, 2016

Fixes #988 if both Travis and AppVeyor passes 🙏

I pinned the electron-builder version because semver's ^ was causing a lot of trouble – some people were able to reproduce the issue, some people weren't, some builds passed on CI, some builds didn't 😕

HUGE thanks to @vors#999 😄
HUGE thanks to @stefanivic for helping to debug it on zeit.chat 🙌

@vors
Copy link
Contributor

vors commented Nov 16, 2016

AppVeyor takes too much time to build because the previous build is affected and it chuckled the queue. You can cancel it to speed-up things. https://ci.appveyor.com/project/appveyor-zeit/hyper/build/1.0.106

@matheuss matheuss merged commit 0585607 into master Nov 16, 2016
@matheuss matheuss deleted the fix/pty.js-build branch November 16, 2016 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants