add command handler to uncatch keyboard event if search is closed#4407
Merged
Stanzilla merged 1 commit intovercel:canaryfrom Mar 25, 2020
Merged
add command handler to uncatch keyboard event if search is closed#4407Stanzilla merged 1 commit intovercel:canaryfrom
Stanzilla merged 1 commit intovercel:canaryfrom
Conversation
2 tasks
LabhanshAgrawal
force-pushed
the
SearchBox
branch
from
4e8f4eb to
b3185c5
Compare
Contributor
|
Worked well here, thank you! |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3929
Added a check to see if searchbox is open before dispatching the
SESSION_SEARCH_CLOSEaction and setcatchedto false if it isn't so that xterm is able to receive it.Doing it by using a command handler, had to provide
dispatchto command handlers for this to work.Do test it out to see if it's working properly, and not impacting any plugins.