Skip to content

Fix international tilde character, and ` and ´#584

Merged
MrRio merged 11 commits intomasterfrom
fix-international-tilde
Aug 10, 2016
Merged

Fix international tilde character, and ` and ´#584
MrRio merged 11 commits intomasterfrom
fix-international-tilde

Conversation

@MrRio
Copy link
Contributor

@MrRio MrRio commented Aug 6, 2016

Alt+N is a tilde character on all tested international keyboard layouts, as well as on UK and US.

@MrRio MrRio mentioned this pull request Aug 6, 2016
Closed
@MrRio
Copy link
Contributor Author

MrRio commented Aug 6, 2016

This should work well enough for now until #214 lands

@crunchtime-ali
Copy link

crunchtime-ali commented Aug 6, 2016 •
edited
Loading

It fixes the non working tilde ~.
However the ` and ´ still don't work.

The debug-output of \´ is {"key":"Dead","code":"Equal","shiftKey":false,"metaKey":false,"altKey":false}"
The debug-output of is{"key":"Dead","code":"Equal","shiftKey":true,"metaKey":false,"altKey":false}"`

image

@MrRio
Copy link
Contributor Author

MrRio commented Aug 6, 2016

Can you send me the debug keycodes for the non-working keys?
On Sat, Aug 6, 2016 at 4:10 PM Ali notifications@github.com wrote:

It fixes the non working tilde ~.
However the "`" still doesn't work.

[image: image]
https://cloud.githubusercontent.com/assets/7140800/17457398/50526e68-5bf7-11e6-8b04-532be4cf847b.png

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#584 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAC5sxSmTsGLY3tNhhS_dyQSIRKZL1ynks5qdKPOgaJpZM4JeSPv
.

James Hall
Director
Parallax Agency Ltd
M. 07894950320

@crunchtime-ali
Copy link

crunchtime-ali commented Aug 6, 2016 •
edited
Loading

Haha, I edited my comment this very second :D

The debug-output of ´ is {"key":"Dead","code":"Equal","shiftKey":false,"metaKey":false,"altKey":false}"
The debug-output of is{"key":"Dead","code":"Equal","shiftKey":true,"metaKey":false,"altKey":false}"`

@MrRio
Copy link
Contributor Author

MrRio commented Aug 10, 2016

This has been extended to cover ` and ´

@MrRio MrRio changed the title Fix international tilde character Fix international tilde character, and ` and ´ Aug 10, 2016
crunchtime-ali
crunchtime-ali reviewed Aug 10, 2016
View reviewed changes
lib/hterm.js
return;
}
// German keyboard layout
if (e.code === 'Equal' && e.shiftKey === false) {
Copy link

@crunchtime-ali crunchtime-ali Aug 10, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

won't that likely cause issues with other keyboard layouts because on another layout it may mean something different.

@lordgiotto
Copy link
Contributor

lordgiotto commented Aug 10, 2016

Tilde and backquotes works here with Italian keyboard. Still a small issue that prevents me to do ´ only with bash, but it's related to metakey bash special functions, and seems to affect only me. On nano or vi all that keys works perfectly ;)
So, for me it's ok!

@lordgiotto
Copy link
Contributor

lordgiotto commented Aug 10, 2016

MetaKey bug that prevents me to do ´char is locale related issue. It's related to #441 and will be fixed by #605.

@MrRio MrRio merged commit cb651f6 into master Aug 10, 2016
@MrRio MrRio deleted the fix-international-tilde branch August 10, 2016 17:37
nfcampos pushed a commit to nfcampos/hyperterm that referenced this pull request Aug 14, 2016
revert vercel#521 and vercel#584 temporary fixes for some composed ch…
989cb6f 
…aracters
chabou added a commit to chabou/hyper that referenced this pull request Aug 19, 2016
@chabou
Merge branch 'master' into wrong_session_exit
ad12ea8 
* master:
  chore(package): update react to version 15.3.1 (vercel#637)
  Fix vercel#527: validate cursorColor value and apply default if it fails (vercel#590)
  Added customChildrenBefore to the tabs. (vercel#580)
  Fix for markdown files (vercel#618)
  Provide clear selection of text in terminal view (vercel#608)
  Added shellArgs to the config. (vercel#572)
  Fix international tilde character, and ` and ´ (vercel#584)
  chore(package): update electron-prebuilt to version 1.3.3 (vercel#604)
  chore(package): update should to version 11.0.0 (vercel#602)
  Comments for ignored stuff
  A little shorter
  Unneeded space
  Open new window offset from last focused window (Credit: albinekb) (vercel#581)
  Fix maximizing behaviour (vercel#176)
  Fix mapXDispatch and allow plugin to access onWheel (credit: lkzhao) (vercel#578)
  Use single quotes for better compatibility (vercel#575)
  Add config for bell (vercel#468)
  chore(package): update electron-prebuilt to version 1.3.2 (vercel#553)
  Moved "file-uri-to-path" dep to app package.json (vercel#569)
@chabou
Copy link
Contributor

chabou commented Aug 19, 2016

it fixes the ~ key on french keyboard.

But there is still a problem with ``` key {"key":"Dead","code":"Backslash","shiftKey":false,"metaKey":false,"altKey":false}

And ^ key {"key":"Dead","code":"BracketLeft","shiftKey":false,"metaKey":false,"altKey":false}

I can make a PR for these keys if needed

@chabou chabou mentioned this pull request Aug 19, 2016
Merged
@timothyis timothyis added this to the v0.8.0 milestone Aug 29, 2016
nfcampos pushed a commit to nfcampos/hyperterm that referenced this pull request Sep 3, 2016
@nfcampos
revert vercel#521 and vercel#584 temporary fixes for some composed ch…
5325783 
…aracters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@MrRio @crunchtime-ali @lordgiotto @chabou @timothyis @lkzhao