Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses a memory leak issue in the SSE (Server-Sent Events) handling logic of the MCP API handler by introducing robust resource cleanup and tracking mechanisms. The main improvements include using a
WeakMapto track server metadata, implementing comprehensive cleanup routines for SSE connections, and ensuring all Redis subscriptions and timers are properly released. These changes help prevent resource leaks and improve the stability and reliability of the SSE endpoints.Memory leak prevention and resource management:
WeakMap(serverMetadata) to track metadata for eachMcpServerinstance, allowing for automatic garbage collection when servers are no longer referenced.cleanupfunction that handles timer clearing, Redis unsubscription, event detachment, and memory release for each connection. This function is now invoked on multiple events (connection close, error, abort, or timeout). [1] [2] [3]/sseand/messageendpoints, even in error or timeout scenarios, preventing resource leaks. [1] [2]Bug fix: