-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add/styled jsx swc #29005
Add/styled jsx swc #29005
Conversation
This comment has been minimized.
This comment has been minimized.
if let Expr::Ident(Ident { sym, .. }) = &**e { | ||
if sym == "import" { | ||
if let Expr::Lit(Lit::Str(Str { value, .. })) = &*expr.args[0].expr { | ||
self.dynamically_imported_specifier = Some(value.to_string()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Not important)
This will panic with a bad error message if argument does not exist.
if let Some(Expr::Lit(Lit::Str(Str { value, .. }))) = expr.args.get(0).as_ref().map(|arg| &*arg.expr) {
}
will work, and you can add an else clause to report an error with readable error message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a check with a handler message and an early return down below which should prevent the two panics you mentioned I think. I need to make sure the errors are being displayed nicely and plan to test out all of the error scenarios in a follow up.
} | ||
} | ||
self.is_next_dynamic_first_arg = true; | ||
expr.args[0].expr = expr.args[0].expr.clone().fold_with(self); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Not important)
Similar problem.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Tim Neutkens <tim@timneutkens.nl>
This comment has been minimized.
This comment has been minimized.
Failing test suitesCommit: 50a9025 test/development/acceptance/ReactRefreshLogBoxMisc.test.ts
Expand output● ReactRefreshLogBox › with multiple children
● ReactRefreshLogBox › component props errors
|
This comment has been minimized.
This comment has been minimized.
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | padmaia/next.js add/styled-jsx-swc | Change | |
---|---|---|---|
buildDuration | 12.2s | 12.1s | -27ms |
buildDurationCached | 3s | 3s | -22ms |
nodeModulesSize | 178 MB | 178 MB | -4 B |
Page Load Tests Overall increase ✓
vercel/next.js canary | padmaia/next.js add/styled-jsx-swc | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.594 | 2.569 | -0.02 |
/ avg req/sec | 963.83 | 973.14 | +9.31 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.265 | 1.265 | ✓ |
/error-in-render avg req/sec | 1976.78 | 1976.14 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | padmaia/next.js add/styled-jsx-swc | Change | |
---|---|---|---|
745.HASH.js gzip | 179 B | 179 B | ✓ |
framework-HASH.js gzip | 42.2 kB | 42.2 kB | ✓ |
main-HASH.js gzip | 26.6 kB | 26.6 kB | ✓ |
webpack-HASH.js gzip | 1.45 kB | 1.45 kB | ✓ |
Overall change | 70.4 kB | 70.4 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | padmaia/next.js add/styled-jsx-swc | Change | |
---|---|---|---|
polyfills-a4..dd70.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | padmaia/next.js add/styled-jsx-swc | Change | |
---|---|---|---|
_app-HASH.js gzip | 979 B | 979 B | ✓ |
_error-HASH.js gzip | 194 B | 194 B | ✓ |
amp-HASH.js gzip | 312 B | 312 B | ✓ |
css-HASH.js gzip | 329 B | 329 B | ✓ |
dynamic-HASH.js gzip | 2.67 kB | 2.67 kB | ✓ |
head-HASH.js gzip | 351 B | 351 B | ✓ |
hooks-HASH.js gzip | 918 B | 918 B | ✓ |
image-HASH.js gzip | 4.14 kB | 4.14 kB | ✓ |
index-HASH.js gzip | 261 B | 261 B | ✓ |
link-HASH.js gzip | 1.66 kB | 1.66 kB | ✓ |
routerDirect..HASH.js gzip | 318 B | 318 B | ✓ |
script-HASH.js gzip | 387 B | 387 B | ✓ |
withRouter-HASH.js gzip | 320 B | 320 B | ✓ |
bb14e60e810b..30f.css gzip | 125 B | 125 B | ✓ |
Overall change | 13 kB | 13 kB | ✓ |
Client Build Manifests
vercel/next.js canary | padmaia/next.js add/styled-jsx-swc | Change | |
---|---|---|---|
_buildManifest.js gzip | 492 B | 492 B | ✓ |
Overall change | 492 B | 492 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | padmaia/next.js add/styled-jsx-swc | Change | |
---|---|---|---|
index.html gzip | 540 B | 540 B | ✓ |
link.html gzip | 552 B | 552 B | ✓ |
withRouter.html gzip | 533 B | 533 B | ✓ |
Overall change | 1.63 kB | 1.63 kB | ✓ |
Default Build with SWC (Increase detected ⚠️ )
General Overall decrease ✓
vercel/next.js canary | padmaia/next.js add/styled-jsx-swc | Change | |
---|---|---|---|
buildDuration | 6.2s | 6.1s | -46ms |
buildDurationCached | 3s | 3s | -7ms |
nodeModulesSize | 178 MB | 178 MB | -4 B |
Page Load Tests Overall increase ✓
vercel/next.js canary | padmaia/next.js add/styled-jsx-swc | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.576 | 2.559 | -0.02 |
/ avg req/sec | 970.51 | 977.03 | +6.52 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.292 | 1.239 | -0.05 |
/error-in-render avg req/sec | 1935.51 | 2017.78 | +82.27 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | padmaia/next.js add/styled-jsx-swc | Change | |
---|---|---|---|
264.HASH.js gzip | 179 B | 179 B | ✓ |
675-HASH.js gzip | 13.8 kB | 13.8 kB | ✓ |
framework-HASH.js gzip | 50.7 kB | 50.7 kB | ✓ |
main-HASH.js gzip | 34.4 kB | 34.4 kB | ✓ |
webpack-HASH.js gzip | 1.65 kB | 1.65 kB | ✓ |
Overall change | 101 kB | 101 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | padmaia/next.js add/styled-jsx-swc | Change | |
---|---|---|---|
polyfills-a4..dd70.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | padmaia/next.js add/styled-jsx-swc | Change | |
---|---|---|---|
_app-HASH.js gzip | 1.33 kB | 1.33 kB | ✓ |
_error-HASH.js gzip | 179 B | 179 B | ✓ |
amp-HASH.js gzip | 331 B | 331 B | ✓ |
css-HASH.js gzip | 352 B | 352 B | ✓ |
dynamic-HASH.js gzip | 2.8 kB | 2.8 kB | ✓ |
head-HASH.js gzip | 356 B | 356 B | ✓ |
hooks-HASH.js gzip | 652 B | 652 B | ✓ |
image-HASH.js gzip | 575 B | 575 B | ✓ |
index-HASH.js gzip | 261 B | 261 B | ✓ |
link-HASH.js gzip | 2.2 kB | 2.2 kB | ✓ |
routerDirect..HASH.js gzip | 327 B | 327 B | ✓ |
script-HASH.js gzip | 392 B | 392 B | ✓ |
withRouter-HASH.js gzip | 323 B | 323 B | ✓ |
bb14e60e810b..30f.css gzip | 125 B | 125 B | ✓ |
Overall change | 10.2 kB | 10.2 kB | ✓ |
Client Build Manifests
vercel/next.js canary | padmaia/next.js add/styled-jsx-swc | Change | |
---|---|---|---|
_buildManifest.js gzip | 515 B | 515 B | ✓ |
Overall change | 515 B | 515 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | padmaia/next.js add/styled-jsx-swc | Change | |
---|---|---|---|
index.html gzip | 538 B | 538 B | ✓ |
link.html gzip | 552 B | 552 B | ✓ |
withRouter.html gzip | 532 B | 532 B | ✓ |
Overall change | 1.62 kB | 1.62 kB | ✓ |
* canary: (41 commits) Add client-side debugging instructions (vercel#28815) v11.1.3-canary.19 Update next-swc binaries (vercel#29132) Fix partial one off global selectors (vercel#29128) Update trace ignores for next import (vercel#29119) Development tracing improvements (vercel#29076) Remove log from failing to parse source map (vercel#29118) Remove inert font tag in font optimization (vercel#28869) v11.1.3-canary.18 Update Redux example to use Toolkit + update dependencies. (vercel#29104) Ensure browser instances are not re-created un-necessarily (vercel#29091) Update styled-jsx (vercel#29103) v11.1.3-canary.17 Add/styled jsx swc (vercel#29005) v11.1.3-canary.16 Fix host segment replacing for custom routes (vercel#29090) Add stats config for SWC (vercel#28883) reload the page to show 404 when receiving `invalid` event from on-demand-entries (vercel#29074) Add crossOrigin type to the NextConfig (vercel#29033) Fix/upload binary artifact (vercel#29069) ...
Swc version of styled-jsx
Bug
fixes #number
contributing.md
Feature
fixes #number
contributing.md
Documentation / Examples