Fix/upload binary artifact

[padmaia]

This should fix false positives on the check precompiled step.

Bug

• Related issues linked using fixes #number
• Integration tests added
• Errors have helpful link attached, see contributing.md

Feature

• Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
• Related issues linked using fixes #number
• Integration tests added
• Documentation added
• Telemetry added. In case of a feature if it's used or not.
• Errors have helpful link attached, see contributing.md

Documentation / Examples

• Make sure the linting passes

[ijjk]

Stats from current PR

Default Build

General

	vercel/next.js canary	padmaia/next.js fix/upload-binary-artifact	Change
buildDuration	12.3s	12.3s	⚠️ +65ms
buildDurationCached	3.1s	3.1s	-47ms
nodeModulesSize	47 MB	47 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	padmaia/next.js fix/upload-binary-artifact	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.624	2.589	-0.04
/ avg req/sec	952.59	965.6	+13.01
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.259	1.266	⚠️ +0.01
/error-in-render avg req/sec	1985.56	1974.03	⚠️ -11.53

Client Bundles (main, webpack, commons)

	vercel/next.js canary	padmaia/next.js fix/upload-binary-artifact	Change
745.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	26.6 kB	26.6 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	70.4 kB	70.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	padmaia/next.js fix/upload-binary-artifact	Change
polyfills-a4..dd70.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	padmaia/next.js fix/upload-binary-artifact	Change
_app-HASH.js gzip	979 B	979 B	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	329 B	329 B	✓
dynamic-HASH.js gzip	2.67 kB	2.67 kB	✓
head-HASH.js gzip	351 B	351 B	✓
hooks-HASH.js gzip	918 B	918 B	✓
image-HASH.js gzip	4.14 kB	4.14 kB	✓
index-HASH.js gzip	261 B	261 B	✓
link-HASH.js gzip	1.66 kB	1.66 kB	✓
routerDirect..HASH.js gzip	318 B	318 B	✓
script-HASH.js gzip	387 B	387 B	✓
withRouter-HASH.js gzip	320 B	320 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	13 kB	13 kB	✓

Client Build Manifests

	vercel/next.js canary	padmaia/next.js fix/upload-binary-artifact	Change
_buildManifest.js gzip	492 B	492 B	✓
Overall change	492 B	492 B	✓

Rendered Page Sizes

	vercel/next.js canary	padmaia/next.js fix/upload-binary-artifact	Change
index.html gzip	539 B	539 B	✓
link.html gzip	552 B	552 B	✓
withRouter.html gzip	533 B	533 B	✓
Overall change	1.62 kB	1.62 kB	✓

---

Webpack 4 Mode (Increase detected ⚠️)

General

	vercel/next.js canary	padmaia/next.js fix/upload-binary-artifact	Change
buildDuration	9.9s	10s	⚠️ +150ms
buildDurationCached	4.1s	4.1s	-8ms
nodeModulesSize	47 MB	47 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	padmaia/next.js fix/upload-binary-artifact	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.624	2.607	-0.02
/ avg req/sec	952.82	959.05	+6.23
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.279	1.247	-0.03
/error-in-render avg req/sec	1954.43	2004.69	+50.26

Client Bundles (main, webpack, commons)

	vercel/next.js canary	padmaia/next.js fix/upload-binary-artifact	Change
16.HASH.js gzip	186 B	186 B	✓
677f882d2ed8..HASH.js gzip	14.1 kB	14.1 kB	✓
framework.HASH.js gzip	41.9 kB	41.9 kB	✓
main-HASH.js gzip	13.8 kB	13.8 kB	✓
webpack-HASH.js gzip	1.19 kB	1.19 kB	✓
Overall change	71.2 kB	71.2 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	padmaia/next.js fix/upload-binary-artifact	Change
polyfills-a4..dd70.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	padmaia/next.js fix/upload-binary-artifact	Change
_app-HASH.js gzip	964 B	964 B	✓
_error-HASH.js gzip	3.8 kB	3.8 kB	✓
amp-HASH.js gzip	552 B	552 B	✓
css-HASH.js gzip	333 B	333 B	✓
dynamic-HASH.js gzip	2.87 kB	2.87 kB	✓
head-HASH.js gzip	3.06 kB	3.06 kB	✓
hooks-HASH.js gzip	924 B	924 B	✓
index-HASH.js gzip	231 B	231 B	✓
link-HASH.js gzip	1.64 kB	1.64 kB	✓
routerDirect..HASH.js gzip	298 B	298 B	✓
script-HASH.js gzip	3.03 kB	3.03 kB	✓
withRouter-HASH.js gzip	295 B	295 B	✓
30809af5c834..565.css gzip	125 B	125 B	✓
Overall change	18.1 kB	18.1 kB	✓

Client Build Manifests

	vercel/next.js canary	padmaia/next.js fix/upload-binary-artifact	Change
_buildManifest.js gzip	500 B	500 B	✓
Overall change	500 B	500 B	✓

Rendered Page Sizes

	vercel/next.js canary	padmaia/next.js fix/upload-binary-artifact	Change
index.html gzip	585 B	585 B	✓
link.html gzip	597 B	597 B	✓
withRouter.html gzip	578 B	578 B	✓
Overall change	1.76 kB	1.76 kB	✓

Commit: 65a7351

[ijjk]

Failing test suites

Commit: 65a7351

test/integration/prerender/test/index.test.js

• SSG Prerender > serverless mode > should reload page on failed data request, and retry

Expand output

● SSG Prerender › serverless mode › should reload page on failed data request, and retry

page.waitForSelector: Timeout 30000ms exceeded.
=========================== logs ===========================
waiting for selector "#params"
============================================================

  200 |     return this.chain(() => {
  201 |       return page
> 202 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  203 |         .then(async (el) => {
  204 |           // it seems selenium waits longer and tests rely on this behavior
  205 |           // so we wait for the load event fire before returning

  at lib/browsers/playwright.ts:202:10