-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add crossOrigin type to the NextConfig #29033
Conversation
@@ -140,6 +140,7 @@ export type NextConfig = { [key: string]: any } & { | |||
isrMemoryCacheSize?: number | |||
nftTracing?: boolean | |||
concurrentFeatures?: boolean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this shouldn't be in the experimental section, related code
next.js/packages/next/build/webpack-config.ts
Line 663 in 93bac0f
const crossOrigin = config.crossOrigin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Thank you.
This comment has been minimized.
This comment has been minimized.
1f4e730
to
4bd7e74
Compare
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | sinchang-codespaces/next.js update-nextconfig-type | Change | |
---|---|---|---|
buildDuration | 12s | 12.2s | |
buildDurationCached | 3.1s | 3.1s | -34ms |
nodeModulesSize | 47 MB | 47 MB |
Page Load Tests Overall increase ✓
vercel/next.js canary | sinchang-codespaces/next.js update-nextconfig-type | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.565 | 2.573 | |
/ avg req/sec | 974.75 | 971.65 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.258 | 1.239 | -0.02 |
/error-in-render avg req/sec | 1987.91 | 2017.49 | +29.58 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | sinchang-codespaces/next.js update-nextconfig-type | Change | |
---|---|---|---|
745.HASH.js gzip | 179 B | 179 B | ✓ |
framework-HASH.js gzip | 42.2 kB | 42.2 kB | ✓ |
main-HASH.js gzip | 26.6 kB | 26.6 kB | ✓ |
webpack-HASH.js gzip | 1.45 kB | 1.45 kB | ✓ |
Overall change | 70.4 kB | 70.4 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | sinchang-codespaces/next.js update-nextconfig-type | Change | |
---|---|---|---|
polyfills-a4..dd70.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | sinchang-codespaces/next.js update-nextconfig-type | Change | |
---|---|---|---|
_app-HASH.js gzip | 979 B | 979 B | ✓ |
_error-HASH.js gzip | 194 B | 194 B | ✓ |
amp-HASH.js gzip | 312 B | 312 B | ✓ |
css-HASH.js gzip | 329 B | 329 B | ✓ |
dynamic-HASH.js gzip | 2.67 kB | 2.67 kB | ✓ |
head-HASH.js gzip | 351 B | 351 B | ✓ |
hooks-HASH.js gzip | 918 B | 918 B | ✓ |
image-HASH.js gzip | 4.14 kB | 4.14 kB | ✓ |
index-HASH.js gzip | 261 B | 261 B | ✓ |
link-HASH.js gzip | 1.66 kB | 1.66 kB | ✓ |
routerDirect..HASH.js gzip | 318 B | 318 B | ✓ |
script-HASH.js gzip | 387 B | 387 B | ✓ |
withRouter-HASH.js gzip | 320 B | 320 B | ✓ |
bb14e60e810b..30f.css gzip | 125 B | 125 B | ✓ |
Overall change | 13 kB | 13 kB | ✓ |
Client Build Manifests
vercel/next.js canary | sinchang-codespaces/next.js update-nextconfig-type | Change | |
---|---|---|---|
_buildManifest.js gzip | 492 B | 492 B | ✓ |
Overall change | 492 B | 492 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | sinchang-codespaces/next.js update-nextconfig-type | Change | |
---|---|---|---|
index.html gzip | 539 B | 539 B | ✓ |
link.html gzip | 552 B | 552 B | ✓ |
withRouter.html gzip | 533 B | 533 B | ✓ |
Overall change | 1.62 kB | 1.62 kB | ✓ |
Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary | sinchang-codespaces/next.js update-nextconfig-type | Change | |
---|---|---|---|
buildDuration | 9.9s | 10s | |
buildDurationCached | 4.3s | 4.1s | -261ms |
nodeModulesSize | 47 MB | 47 MB |
Page Load Tests Overall decrease ⚠️
vercel/next.js canary | sinchang-codespaces/next.js update-nextconfig-type | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.642 | 2.688 | |
/ avg req/sec | 946.37 | 930.09 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.265 | 1.324 | |
/error-in-render avg req/sec | 1976.92 | 1887.74 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | sinchang-codespaces/next.js update-nextconfig-type | Change | |
---|---|---|---|
16.HASH.js gzip | 186 B | 186 B | ✓ |
677f882d2ed8..HASH.js gzip | 14.1 kB | 14.1 kB | ✓ |
framework.HASH.js gzip | 41.9 kB | 41.9 kB | ✓ |
main-HASH.js gzip | 13.8 kB | 13.8 kB | ✓ |
webpack-HASH.js gzip | 1.19 kB | 1.19 kB | ✓ |
Overall change | 71.2 kB | 71.2 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | sinchang-codespaces/next.js update-nextconfig-type | Change | |
---|---|---|---|
polyfills-a4..dd70.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | sinchang-codespaces/next.js update-nextconfig-type | Change | |
---|---|---|---|
_app-HASH.js gzip | 964 B | 964 B | ✓ |
_error-HASH.js gzip | 3.8 kB | 3.8 kB | ✓ |
amp-HASH.js gzip | 552 B | 552 B | ✓ |
css-HASH.js gzip | 333 B | 333 B | ✓ |
dynamic-HASH.js gzip | 2.87 kB | 2.87 kB | ✓ |
head-HASH.js gzip | 3.06 kB | 3.06 kB | ✓ |
hooks-HASH.js gzip | 924 B | 924 B | ✓ |
index-HASH.js gzip | 231 B | 231 B | ✓ |
link-HASH.js gzip | 1.64 kB | 1.64 kB | ✓ |
routerDirect..HASH.js gzip | 298 B | 298 B | ✓ |
script-HASH.js gzip | 3.03 kB | 3.03 kB | ✓ |
withRouter-HASH.js gzip | 295 B | 295 B | ✓ |
30809af5c834..565.css gzip | 125 B | 125 B | ✓ |
Overall change | 18.1 kB | 18.1 kB | ✓ |
Client Build Manifests
vercel/next.js canary | sinchang-codespaces/next.js update-nextconfig-type | Change | |
---|---|---|---|
_buildManifest.js gzip | 500 B | 500 B | ✓ |
Overall change | 500 B | 500 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | sinchang-codespaces/next.js update-nextconfig-type | Change | |
---|---|---|---|
index.html gzip | 585 B | 585 B | ✓ |
link.html gzip | 597 B | 597 B | ✓ |
withRouter.html gzip | 578 B | 578 B | ✓ |
Overall change | 1.76 kB | 1.76 kB | ✓ |
* canary: (41 commits) Add client-side debugging instructions (vercel#28815) v11.1.3-canary.19 Update next-swc binaries (vercel#29132) Fix partial one off global selectors (vercel#29128) Update trace ignores for next import (vercel#29119) Development tracing improvements (vercel#29076) Remove log from failing to parse source map (vercel#29118) Remove inert font tag in font optimization (vercel#28869) v11.1.3-canary.18 Update Redux example to use Toolkit + update dependencies. (vercel#29104) Ensure browser instances are not re-created un-necessarily (vercel#29091) Update styled-jsx (vercel#29103) v11.1.3-canary.17 Add/styled jsx swc (vercel#29005) v11.1.3-canary.16 Fix host segment replacing for custom routes (vercel#29090) Add stats config for SWC (vercel#28883) reload the page to show 404 when receiving `invalid` event from on-demand-entries (vercel#29074) Add crossOrigin type to the NextConfig (vercel#29033) Fix/upload binary artifact (vercel#29069) ...
Bug
fixes #number
contributing.md
Feature
fixes #number
contributing.md
Documentation / Examples