Add stats config for SWC #28883

timneutkens · 2021-09-07T14:22:04Z

Adds PR stats with SWC minification and loader enabled. Also removes PR stats for webpack 4 as it's now deprecated.

Bug

Related issues linked using fixes #number
Integration tests added
Errors have helpful link attached, see contributing.md

Feature

Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
Related issues linked using fixes #number
Integration tests added
Documentation added
Telemetry added. In case of a feature if it's used or not.
Errors have helpful link attached, see contributing.md

Documentation / Examples

Make sure the linting passes

…-config

… into add/swc-stats-config

…-config

… into add/swc-stats-config

…-config # Conflicts: # packages/next/native/next-swc.win32-x64-msvc.node

ijjk · 2021-09-14T15:45:26Z

Failing test suites

Commit: 996198b

test/integration/app-document-remove-hmr/test/index.test.js

_app removal HMR > should HMR when _document is removed

Expand output

● _app removal HMR › should HMR when _document is removed

TIMED OUT: success

<head><meta charset="utf-8"><meta name="viewport" content="width=device-width"><meta name="next-head-count" content="2"><noscript data-n-css=""></noscript><script defer="" nomodule="" src="/_next/static/chunks/polyfills.js?ts=1631634285340"></script><script src="/_next/static/chunks/webpack.js?ts=1631634285340" defer=""></script><script src="/_next/static/chunks/main.js?ts=1631634285340" defer=""></script><script src="/_next/static/chunks/pages/_app.js?ts=1631634285340" defer=""></script><script src="/_next/static/chunks/pages/index.js?ts=1631634285340" defer=""></script><script src="/_next/static/development/_buildManifest.js?ts=1631634285340" defer=""></script><script src="/_next/static/development/_ssgManifest.js?ts=1631634285340" defer=""></script><noscript id="__next_css__DO_NOT_USE__"></noscript></head><body><p>custom _document</p><div id="__next"><p>custom _app</p><p>index page</p></div><script src="/_next/static/chunks/react-refresh.js?ts=1631634285340"></script><script id="__NEXT_DATA__" type="application/json">{"props":{"pageProps":{}},"page":"/","query":{},"buildId":"development","nextExport":true,"autoExport":true,"isFallback":false,"scriptLoader":[]}</script><div id="__next-build-watcher" style="position: fixed; bottom: 10px; right: 20px; width: 0px; height: 0px; z-index: 99999;"></div><next-route-announcer><p aria-live="assertive" id="__next-route-announcer__" role="alert" style="border: 0px; clip: rect(0px, 0px, 0px, 0px); height: 1px; margin: -1px; overflow: hidden; padding: 0px; position: absolute; width: 1px; white-space: nowrap; overflow-wrap: normal;"></p></next-route-announcer></body>

  440 |
  441 |   if (hardError) {
> 442 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  443 |   }
  444 |   return false
  445 | }

  at Object.check (lib/next-test-utils.js:442:11)
  at Object.<anonymous> (integration/app-document-remove-hmr/test/index.test.js:123:7)

ijjk · 2021-09-14T15:48:17Z

Stats from current PR

Default Build (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add/swc-stats-config	Change
buildDuration	12.2s	12.1s	-109ms
buildDurationCached	3.1s	3s	-85ms
nodeModulesSize	178 MB	178 MB	⚠️ +4.75 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	timneutkens/next.js add/swc-stats-config	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.566	2.558	-0.01
/ avg req/sec	974.35	977.23	+2.88
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.251	1.268	⚠️ +0.02
/error-in-render avg req/sec	1997.64	1971.83	⚠️ -25.81

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/swc-stats-config	Change
745.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	26.6 kB	26.6 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	70.4 kB	70.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/swc-stats-config	Change
polyfills-a4..dd70.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/swc-stats-config	Change
_app-HASH.js gzip	979 B	979 B	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	329 B	329 B	✓
dynamic-HASH.js gzip	2.67 kB	2.67 kB	✓
head-HASH.js gzip	351 B	351 B	✓
hooks-HASH.js gzip	918 B	918 B	✓
image-HASH.js gzip	4.14 kB	4.14 kB	✓
index-HASH.js gzip	261 B	261 B	✓
link-HASH.js gzip	1.66 kB	1.66 kB	✓
routerDirect..HASH.js gzip	318 B	318 B	✓
script-HASH.js gzip	387 B	387 B	✓
withRouter-HASH.js gzip	320 B	320 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	13 kB	13 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/swc-stats-config	Change
_buildManifest.js gzip	492 B	492 B	✓
Overall change	492 B	492 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js add/swc-stats-config	Change
index.html gzip	539 B	539 B	✓
link.html gzip	552 B	552 B	✓
withRouter.html gzip	533 B	533 B	✓
Overall change	1.62 kB	1.62 kB	✓

Default Build with SWC (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add/swc-stats-config	Change
buildDuration	6.2s	6.2s	-5ms
buildDurationCached	3s	3s	-45ms
nodeModulesSize	178 MB	178 MB	⚠️ +4.75 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	timneutkens/next.js add/swc-stats-config	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.564	2.548	-0.02
/ avg req/sec	975.08	981.26	+6.18
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.282	1.3	⚠️ +0.02
/error-in-render avg req/sec	1949.38	1923.68	⚠️ -25.7

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/swc-stats-config	Change
264.HASH.js gzip	179 B	179 B	✓
675-HASH.js gzip	13.8 kB	13.8 kB	✓
framework-HASH.js gzip	50.7 kB	50.7 kB	✓
main-HASH.js gzip	34.4 kB	34.4 kB	✓
webpack-HASH.js gzip	1.65 kB	1.65 kB	✓
Overall change	101 kB	101 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/swc-stats-config	Change
polyfills-a4..dd70.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages Overall decrease ✓

	vercel/next.js canary	timneutkens/next.js add/swc-stats-config	Change
_app-HASH.js gzip	1.33 kB	1.33 kB	✓
_error-HASH.js gzip	179 B	179 B	✓
amp-HASH.js gzip	331 B	331 B	✓
css-HASH.js gzip	352 B	352 B	✓
dynamic-HASH.js gzip	2.82 kB	2.8 kB	-22 B
head-HASH.js gzip	356 B	356 B	✓
hooks-HASH.js gzip	652 B	652 B	✓
image-HASH.js gzip	575 B	575 B	✓
index-HASH.js gzip	261 B	261 B	✓
link-HASH.js gzip	2.2 kB	2.2 kB	✓
routerDirect..HASH.js gzip	327 B	327 B	✓
script-HASH.js gzip	392 B	392 B	✓
withRouter-HASH.js gzip	323 B	323 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	10.2 kB	10.2 kB	-22 B

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/swc-stats-config	Change
_buildManifest.js gzip	515 B	515 B	✓
Overall change	515 B	515 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js add/swc-stats-config	Change
index.html gzip	539 B	539 B	✓
link.html gzip	551 B	551 B	✓
withRouter.html gzip	530 B	530 B	✓
Overall change	1.62 kB	1.62 kB	✓

Diffs

Diff for _buildManifest.js

@@ -10,7 +10,7 @@ self.__BUILD_MANIFEST = {
     "static\u002Fchunks\u002Fpages\u002Fcss-e7a92c56181df5130dc3.js"
   ],
   "/dynamic": [
-    "static\u002Fchunks\u002Fpages\u002Fdynamic-44d6e5b3095efa4c5a9c.js"
+    "static\u002Fchunks\u002Fpages\u002Fdynamic-38c6655d7b7dbcd3521a.js"
   ],
   "/head": ["static\u002Fchunks\u002Fpages\u002Fhead-1ef778566fc646ae3c10.js"],
   "/hooks": [

Diff for dynamic-HASH.js

@@ -600,10 +600,7 @@
             webpack: function() {
               return [/*require.resolve*/ 2169];
             },
-            modules: [
-              "/next-stats/.work/stats-app/pages/dynamic.js -> " +
-                "../components/hello"
-            ]
+            modules: ["dynamic.js -> " + "../components/hello"]
           }
         }
       );

Commit: 996198b

* canary: (41 commits) Add client-side debugging instructions (vercel#28815) v11.1.3-canary.19 Update next-swc binaries (vercel#29132) Fix partial one off global selectors (vercel#29128) Update trace ignores for next import (vercel#29119) Development tracing improvements (vercel#29076) Remove log from failing to parse source map (vercel#29118) Remove inert font tag in font optimization (vercel#28869) v11.1.3-canary.18 Update Redux example to use Toolkit + update dependencies. (vercel#29104) Ensure browser instances are not re-created un-necessarily (vercel#29091) Update styled-jsx (vercel#29103) v11.1.3-canary.17 Add/styled jsx swc (vercel#29005) v11.1.3-canary.16 Fix host segment replacing for custom routes (vercel#29090) Add stats config for SWC (vercel#28883) reload the page to show 404 when receiving `invalid` event from on-demand-entries (vercel#29074) Add crossOrigin type to the NextConfig (vercel#29033) Fix/upload binary artifact (vercel#29069) ...

Add stats config for SWC

d30891c

timneutkens requested review from huozhi, ijjk, padmaia, shuding and styfle as code owners September 7, 2021 14:22

ijjk added the created-by: Next.js team PRs by the Next.js team. label Sep 7, 2021

Remove stats for deprecated mode

c146dee

ijjk previously approved these changes Sep 7, 2021

View reviewed changes

Include native binaries in local linking

6aea626

padmaia dismissed ijjk’s stale review via 6aea626 September 7, 2021 16:34

Expose minify in next-swc

3d10a66

ijjk added the type: next label Sep 7, 2021

padmaia and others added 6 commits September 7, 2021 17:35

Build next-swc binaries

37a5af7

Only upload changed binary artifact

1c964dd

Build next-swc binaries

d00b3f1

Expose minify in js binding

e148bd8

Use new minify function in terser plugin

9de74ff

Merge remote-tracking branch 'upstream/canary' into add/swc-stats-config

5a09f3b

This comment has been minimized.

Sign in to view

timneutkens and others added 2 commits September 9, 2021 14:43

Merge branch 'canary' into add/swc-stats-config

d1424ef

Merge branch 'canary' into add/swc-stats-config

3deb017

This comment has been minimized.

Sign in to view

timneutkens and others added 3 commits September 13, 2021 09:16

Merge branch 'canary' into add/swc-stats-config

64132f2

Merge branch 'canary' of github.com:vercel/next.js into add/swc-stats…

c767cc7

…-config

Merge branch 'canary' into add/swc-stats-config

91fe35c

This comment has been minimized.

Sign in to view

timneutkens and others added 3 commits September 13, 2021 10:51

Build next-swc binaries

4f2f5a9

Merge branch 'add/swc-stats-config' of github.com:timneutkens/next.js…

4d0275a

… into add/swc-stats-config

Build next-swc binaries

03a8379

timneutkens and others added 2 commits September 13, 2021 14:18

Merge branch 'add/swc-stats-config' of github.com:timneutkens/next.js…

f98d04f

… into add/swc-stats-config

Merge branch 'canary' into add/swc-stats-config

1c08e74

This comment has been minimized.

Sign in to view

timneutkens and others added 4 commits September 13, 2021 12:57

Build next-swc binaries

e1957af

Merge branch 'add/swc-stats-config' of github.com:timneutkens/next.js…

bcdf9bf

… into add/swc-stats-config

Merge branch 'canary' into add/swc-stats-config

cdc3796

Merge branch 'add/swc-stats-config' of github.com:timneutkens/next.js…

720850a

… into add/swc-stats-config

This comment has been minimized.

Sign in to view

timneutkens and others added 3 commits September 13, 2021 15:43

Pass pagesDir option to SWC for next/dynamic

f51db68

Merge branch 'canary' of github.com:vercel/next.js into add/swc-stats…

3203bbc

…-config

Build next-swc binaries

db78c51

This comment has been minimized.

Sign in to view

timneutkens added 3 commits September 14, 2021 09:49

Add spans for next-trace-entrypoints-plugin

c0c5cd8

Merge branch 'add/swc-stats-config' of github.com:timneutkens/next.js…

39c0ee8

… into add/swc-stats-config

Merge branch 'canary' of github.com:vercel/next.js into add/swc-stats…

c852360

…-config # Conflicts: # packages/next/native/next-swc.win32-x64-msvc.node

This comment has been minimized.

Sign in to view

Fix linting

e9ec1d6

This comment has been minimized.

Sign in to view

Merge branch 'canary' into add/swc-stats-config

996198b

timneutkens merged commit 7d664d5 into vercel:canary Sep 14, 2021

vercel locked as resolved and limited conversation to collaborators Jan 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add stats config for SWC #28883

Add stats config for SWC #28883

timneutkens commented Sep 7, 2021 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ijjk commented Sep 14, 2021

ijjk commented Sep 14, 2021

Diffs

Add stats config for SWC #28883

Add stats config for SWC #28883

Conversation

timneutkens commented Sep 7, 2021 • edited Loading

Bug

Feature

Documentation / Examples

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ijjk commented Sep 14, 2021

Failing test suites

ijjk commented Sep 14, 2021

Stats from current PR

Diffs

timneutkens commented Sep 7, 2021 •

edited

Loading